Tal Nisan has posted comments on this change.

Change subject: webadmin: improve import conflict (for vm) dialogue
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 2474: 
Line 2475:     @DefaultStringValue("Don't import")
Line 2476:     String cloneDontImport();
Line 2477: 
Line 2478:     @DefaultStringValue("Import as 
cloned<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Changing name, MAC addresses, and 
cloning all disks removing all snapshots")
Btw, here the more elegant solution will be two different messages, one 
displayed as is and the second with left padding instead of the white spaces 
and the break
Line 2479:     String cloneImportVm();
Line 2480: 
Line 2481:     @DefaultStringValue("Clone")
Line 2482:     String cloneImportTemplate();


--
To view, visit http://gerrit.ovirt.org/11435
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6fe863e52e9bad1d620bce75b8252bca4d0d414
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to