Daniel Erez has posted comments on this change. Change subject: frontend: force admin-console only on AdminPortal ......................................................................
Patch Set 1: (1 inline comment) .................................................... File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java Line 51: eventBus.addHandler(UiCommonInitEvent.getType(), this); Line 52: Line 53: // This means that it is UserPortal application. Line 54: setIsAdmin(false); Line 55: setSpiceAdminConsole(false); For keeping symmetry, the parallel statement in Configurator should be moved to WebAdminConfigurator (I.e. add 'setSpiceAdminConsole(true)' to WebAdminConfigurator ctr and remove it from Configurator ctr). Line 56: Line 57: // Add event listeners Line 58: spiceVersionFileFetchedEvent.addListener(this); Line 59: documentationFileFetchedEvent.addListener(this); -- To view, visit http://gerrit.ovirt.org/11484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a5cefd4ba86bdad46851381c1973141e19979ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
