Einav Cohen has posted comments on this change. Change subject: userportal: set grid's items only on change ......................................................................
Patch Set 2: [trying again, hopefully gerrit-text formatting will be better this time...] We need to make sure that we are refreshing the view whenever it needs to be refreshed. Which means a couple of things: 1) For read-only view (grid/sub-tabs/basic-view - see http://gerrit.ovirt.org/#/c/10509/) - need to make sure that view is updated appropriately whenever a relevant business-entity property value changes. So need to take into consideration: - properties that are being displayed [e.g. VmName (appears in the grid), Description (appears as a tool-tip in the grid), DisplayType (appears in the 'General' sub-tab), AppList (appears in the 'applications' sub-tab), etc.] - properties that control display [e.g. the vm_status property, which controls some buttons' availability, such as 'run', 'stop', 'remove', etc]. So all of these - either need to be part of the "equals" method of the relevant business entity (e.g. VmStatic) or specifically referred to in the "shouldBeRefreshed" method (e.g. like "status", which is already there in the patch). 2) For editing view (dialogs) - need to make sure that all the data within the dialog (once opening it) is up-to-date, otherwise it can result in action-requests to the backend that contain obsolete information. This can be achieved by doing one of the following: - make sure that "shouldBeRefreshed" is covering all of the fields for the dialogs (i.e. just like I wrote above for the "read-only view" section: making sure that all the relevant dialogs' fields are part of the relevant "equals" method in the business-entity or referred to explicitly in the "shouldBeRefreshed" method). - retrieve the item from the backend right before opening and filling the dialog with data (e.g. upon "Edit VM" button-click). -- To view, visit http://gerrit.ovirt.org/10579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bd8c3cb312f89125e8c0a0182f49fe74f9f02d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
