Shireesh Anjal has posted comments on this change.
Change subject: engine: Import Cluster with Invalid Password (#894462)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQuery.java
Line 54: protected void executeQueryCommand() {
Line 55: // Check whether the given server is already part of the
cluster
Line 56: if
(getVdsStaticDao().getAllForHost(getParameters().getServerName()).size() > 0
Line 57: ||
getVdsStaticDao().getAllWithIpAddress(getParameters().getServerName()).size() >
0) {
Line 58:
setReturnMessage(VdcBllMessages.SERVER_ALREADY_EXISTS_IN_ANOTHER_CLUSTER.toString());
do you need a return statement here?
Line 59: }
Line 60:
Line 61: SSHClient client = null;
Line 62:
Line 87:
Line 88: private void setReturnMessage(String errorMessage) {
Line 89: getQueryReturnValue().setSucceeded(false);
Line 90: getQueryReturnValue().setExceptionString(errorMessage);
Line 91: return;
why add return at the end of a void method?
Line 92: }
Line 93:
Line 94: /*
Line 95: * The method will return false, if the given server is already
part of the existing cluster, otherwise true.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 830: ENGINE_IS_RUNNING_IN_MAINTENANCE_MODE=Engine is running in
Maintenance mode and is not accepting commands.
Line 831: ENGINE_IS_RUNNING_IN_PREPARE_MODE=This action is not allowed when
Engine is preparing for maintenance.
Line 832: ACTION_TYPE_FAILED_SERVER_NAME_REQUIRED=Cannot ${action} ${type}.
Server Name required.
Line 833: SERVER_ALREADY_EXISTS_IN_ANOTHER_CLUSTER=One or more servers are
already part of an existing cluster.
Line 834: SSH_AUTHENTICATION_FAILED=SSH Authentication failed, Please make sure
root password is correct.
I think we need not say "root password". Just "password" should be enough, so
that the same message can be used when authentication fails for non-root users
as well.
Change the comma to a full stop after "SSH Authentication failed"
Line 835: =======
Line 836: # Exteral Events Errors Messages
Line 837: VAR__TYPE__EXTERNAL_EVENT=$type Exteral Event
Line 838: ACTION_TYPE_FAILED_EXTERNAL_EVENT_ILLEGAL_ORIGIN=Cannot ${action}
${type}. Illegal Origin for External Event : oVirt
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 2207:
Line 2208: @DefaultStringValue("One or more servers are already part of an
existing cluster")
Line 2209: String SERVER_ALREADY_EXISTS_IN_ANOTHER_CLUSTER();
Line 2210:
Line 2211: @DefaultStringValue("SSH Authentication failed, Please make sure
root password is correct.")
Same here.
Line 2212: String SSH_AUTHENTICATION_FAILED();
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 770: USER_CANNOT_FORCE_RECONNECT_TO_VM=Console connection denied. Another
user has already accessed the console of this VM. The VM should be rebooted to
allow another user to access it, or changed by an admin to not enforce reboot
between users accessing its console.
Line 771: ENGINE_IS_RUNNING_IN_MAINTENANCE_MODE=Engine is running in
Maintenance mode and is not accepting commands.
Line 772: ENGINE_IS_RUNNING_IN_PREPARE_MODE=This action is not allowed when
Engine is preparing for maintenance.
Line 773: SERVER_ALREADY_EXISTS_IN_ANOTHER_CLUSTER=One or more servers are
already part of an existing cluster.
Line 774: SSH_AUTHENTICATION_FAILED=SSH Authentication failed, Please make sure
root password is correct.
Same here.
Line 775: # Exteral Events Errors Messages
Line 776: VAR__TYPE__EXTERNAL_EVENT=$type Exteral Event
Line 777: ACTION_TYPE_FAILED_EXTERNAL_EVENT_ILLEGAL_ORIGIN=Cannot ${action}
${type}. Illegal Origin for External Event : oVirt
Line 778: ACTION_TYPE_FAILED_EXTERNAL_EVENT_NOT_FOUND=Cannot ${action}
${type}.External Event does not exist.
--
To view, visit http://gerrit.ovirt.org/11257
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10517a43d2f87bcfe2893f3bb97dbc13afb4915d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
