Michael Kublin has uploaded a new change for review.
Change subject: engine: Remove a dead code from VdsManager
..
engine: Remove a dead code from VdsManager
The following condition was removed from VdsManager because it will ne
Michael Kublin has uploaded a new change for review.
Change subject: core: Removed unneeded quartz job scheduling during run vm
..
core: Removed unneeded quartz job scheduling during run vm
The following patch is simple, I remov
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Fix ownership of deployments and contents
..
Patch Set 1: (1 inline comment)
File packaging/fedora
Vered Volansky has posted comments on this change.
Change subject: core:WIP: introducing OvfAutoUpdate
..
Patch Set 3: (5 inline comments)
Commit Message
Line 13: vms/templat
Vered Volansky has posted comments on this change.
Change subject: core: Default disk aliases when reading OVFs
..
Patch Set 2: (3 inline comments)
File
backend/manager/modu
Vered Volansky has posted comments on this change.
Change subject: core: OvfReader cleanup - document empty blocks
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9304
T
Yair Zaslavsky has posted comments on this change.
Change subject: Adding system information to getCapabilities from host
..
Patch Set 1:
Yaniv, Regarding host_version - is it in format of rpm version?
--
To view, visit http:/
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Don't ask for password, before DNS SRV records are
returned.
..
Patch Set 8:
Followed all Sharad's comments except for one -
JndiAction.ldapDnsResult ca
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1: (11 inline comments)
Mostly style comments.
..
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: all-in-one: depend on ovirt-host-deploy-offline
..
packaging: all-in-one: depend on ovirt-host-deploy-offline
The ovirt-host-deploy-offline configures
Sharad Mishra has posted comments on this change.
Change subject: core: remove redundant constructors from VmStatistics
..
Patch Set 2: (1 inline comment)
File
backend/manag
Sharad Mishra has posted comments on this change.
Change subject: core: OvfReader cleanup - remove StringHelper
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9305
To u
Sharad Mishra has posted comments on this change.
Change subject: core: OvfReader cleanup - remove unused parameter
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9307
Sharad Mishra has posted comments on this change.
Change subject: tools: Don't ask for password, before DNS SRV records are
returned.
..
Patch Set 6: (2 inline comments)
Fil
Daniel Erez has posted comments on this change.
Change subject: core: Adding force extend support to extendVG
..
Patch Set 1: (3 inline comments)
File
backend/manager/module
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding system information to getCapabilities from host
..
Patch Set 1: (3 inline comments)
It is bios information. Those are the parameters that are requested h
Amador Pahim has posted comments on this change.
Change subject: core: correcting max memory for scheduling VMs field
..
Patch Set 2: (1 inline comment)
File
backend/manager
Sharad Mishra has posted comments on this change.
Change subject: core: correcting max memory for scheduling VMs field
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Fix ownership of deployments and contents
..
Patch Set 1: (1 inline comment)
File packaging/fedora
Sharad Mishra has posted comments on this change.
Change subject: core: Extract disk alias generation methods
..
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
.
Juan Hernandez has posted comments on this change.
Change subject: bootstrap: use LocalConfig for engine http host and port
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Juan Hernandez has posted comments on this change.
Change subject: packaging: Fix ownership of deployments and contents
..
Patch Set 2: Verified
Removed fixes to white space included in previous patch. No other changes, so I
a
Juan Hernandez has posted comments on this change.
Change subject: packaging: Fix ownership of deployments and contents
..
Patch Set 1: (2 inline comments)
File packaging/fed
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: use LocalConfig for engine http host and port
..
Patch Set 1: (2 inline comments)
File
backend/ma
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Fix ownership of deployments and contents
..
Patch Set 1: (2 inline comments)
File packaging/fedor
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Don't ask for password, before DNS SRV records are
returned.
..
Patch Set 6: (3 inline comments)
Sharad, thanks for the review.
Please check my comments
Juan Hernandez has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1: (5 inline comments)
...
Yair Zaslavsky has posted comments on this change.
Change subject: core:WIP: introducing OvfAutoUpdate
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules/bll/sr
Juan Hernandez has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1:
Regarding the patch itself, where are you deploying the crowd jar files
Juan Hernandez has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1:
We have that repository in the root POM because we have a transitive de
Juan Hernandez has posted comments on this change.
Change subject: packaging: Fix ownership of deployments and contents
..
Patch Set 1: Verified
Verified in Fedora 17 building and installing new packages from scratch.
Ohad, ca
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Fix ownership of deployments and contents
..
packaging: Fix ownership of deployments and contents
A previous commit (9d5af3) changed the .spec so th
Juan Hernandez has posted comments on this change.
Change subject: bootstrap: use LocalConfig for engine http host and port
..
Patch Set 1: (2 inline comments)
File
backend/
Sharad Mishra has posted comments on this change.
Change subject: tools: Don't ask for password, before DNS SRV records are
returned.
..
Patch Set 6: I would prefer that you didn't submit this
(4 inline comments)
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: use LocalConfig for engine http host and port
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9368
To unsubscribe, visit http://gerr
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: use LocalConfig for engine http host and port
..
Patch Set 1:
Per juan request, use configuration file setting instead of options.
--
To view, visit h
Alon Bar-Lev has uploaded a new change for review.
Change subject: bootstrap: use LocalConfig for engine http host and port
..
bootstrap: use LocalConfig for engine http host and port
This retires the VdcBootStrapUrl, PublicURLP
Sharad Mishra has posted comments on this change.
Change subject: tools: some manage domains cleanup
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9350
To unsubscribe,
Sharad Mishra has posted comments on this change.
Change subject: core: OvfReader cleanup - document empty blocks
..
Patch Set 2: Looks good to me, but someone else must approve
Fail to understand how this fix relates to 72506.
Michael Pasternak has posted comments on this change.
Change subject: Adding system information to getCapabilities from host
..
Patch Set 1: I would prefer that you didn't submit this
please expose BIOS info in api as well.
--
Michael Pasternak has posted comments on this change.
Change subject: Adding system information to getCapabilities from host
..
Patch Set 1:
On 11/20/2012 01:57 PM, yzasl...@redhat.com wrote:
> Yair Zaslavsky has posted comment
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: rewrite bootstrap using the new ovirt-host-deploy
package
..
Patch Set 11: (1 inline comment)
Fil
Juan Hernandez has posted comments on this change.
Change subject: bootstrap: rewrite bootstrap using the new ovirt-host-deploy
package
..
Patch Set 11: (1 inline comment)
F
Arik Hadas has posted comments on this change.
Change subject: webadmin: Fix new/edit pool dialogs for ja locale
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9364
To unsubscribe, visit http://gerrit.ovirt.
Arik Hadas has uploaded a new change for review.
Change subject: webadmin: Fix new/edit pool dialogs for ja locale
..
webadmin: Fix new/edit pool dialogs for ja locale
- Change the layout of some components in the new & edit poo
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: rewrite bootstrap using the new ovirt-host-deploy
package
..
Patch Set 11: (3 inline comments)
Fi
Allon Mureinik has submitted this change and it was merged.
Change subject: core: set storage domain format V3 for DC 3.2
..
core: set storage domain format V3 for DC 3.2
The automatic upgrade mechanism introduced in de5a415 di
Allon Mureinik has posted comments on this change.
Change subject: core: set storage domain format V3 for DC 3.2
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/9249
To un
Juan Hernandez has posted comments on this change.
Change subject: bootstrap: rewrite bootstrap using the new ovirt-host-deploy
package
..
Patch Set 11: (3 inline comments)
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: rewrite bootstrap using the new ovirt-host-deploy
package
..
Patch Set 11: (7 inline comments)
Fi
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2764/
Build Number: 2764
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,482
-
Changes Since
Maor Lipchuk has posted comments on this change.
Change subject: core:WIP: introducing OvfAutoUpdate
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules/common/s
Shahar Havivi has submitted this change and it was merged.
Change subject: engine: cannot run VM when path is null in devices spec-params
..
engine: cannot run VM when path is null in devices spec-params
Change-Id: I1d5e2d67adc
Justin Hammond has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1:
Hi,
Still pending a affirmative reply from Atlassian, but as a side not
Juan Hernandez has posted comments on this change.
Change subject: bootstrap: rewrite bootstrap using the new ovirt-host-deploy
package
..
Patch Set 11: (9 inline comments)
Shahar Havivi has posted comments on this change.
Change subject: engine: cannot run VM when path is null in devices spec-params
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/932
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: rewrite bootstrap using the new ovirt-host-deploy
package
..
Patch Set 11: (27 inline comments)
Thanks for review!
> I would suggest to break the 103
Michael Kublin has posted comments on this change.
Change subject: core: [WIP] Remove global lock on SPM calls from engine side
..
Patch Set 2: I would prefer that you didn't submit this
Fixed additional race
--
To view, visit
Michael Kublin has posted comments on this change.
Change subject: core:WIP: introducing OvfAutoUpdate
..
Patch Set 3: (7 inline comments)
Discussed couple of issues , should be solved at next patch
...
Maor Lipchuk has posted comments on this change.
Change subject: core: OvfReader cleanup - document empty blocks
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9304
To
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: Messages text fixes
..
webadmin: Messages text fixes
In this patch, some fixes were made to some of the messages:
- Network engine is mandatory
Einav Cohen has posted comments on this change.
Change subject: webadmin: Messages text fixes
..
Patch Set 5: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/9095
To unsubscribe, visit ht
Maor Lipchuk has posted comments on this change.
Change subject: core: Adding force extend support to extendVG
..
Patch Set 1: Looks good to me, but someone else must approve
(3 inline comments)
Looks good, minor comments/sugg
Gal Hammer has posted comments on this change.
Change subject: agent: apply virtual-guest tuning profile on installation.
..
Patch Set 1: I would prefer that you didn't submit this
The tuned profile should not be be set by the
Gal Hammer has uploaded a new change for review.
Change subject: agent: apply virtual-guest tuning profile on installation.
..
agent: apply virtual-guest tuning profile on installation.
Change-Id: I9d3d6ee2bd090f5cc37697343e937f
Juan Hernandez has posted comments on this change.
Change subject: bootstrap: rewrite bootstrap using the new ovirt-host-deploy
package
..
Patch Set 11: (29 inline comments)
I would suggest to break the 1030 lines of the VdsDe
Itamar Heim has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1:
not only the integration patches need to have compatible licenses, rather
Maor Lipchuk has posted comments on this change.
Change subject: restapi: Extend block domain - override_luns
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9344
To uns
Vered Volansky has posted comments on this change.
Change subject: core: Messages grammar fixes
..
Patch Set 2: (1 inline comment)
Do not merge
File
backend/manager/modules
Oved Ourfali has posted comments on this change.
Change subject: tools: Don't ask for password, before DNS SRV records are
returned.
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9349
To
Maor Lipchuk has posted comments on this change.
Change subject: core: Messages grammar fixes
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/dal/src/main/re
Doron Fediuck has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1:
Hi Justin,
Thanks for the effort and your time.
The link you provided is
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Don't ask for password, before DNS SRV records are
returned.
..
Patch Set 4: Verified
Verified - see my previous verification, it actually matched this
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Don't ask for password, before DNS SRV records are
returned.
..
Patch Set 3: Verified
(1 inline comment)
Tried adding non existing domain.
Got the foll
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 11:
Sorry, I forgot to address this:
> You say that Java developers are pri
Maor Lipchuk has posted comments on this change.
Change subject: core: Extract disk alias generation methods
..
Patch Set 5: (2 inline comments)
File
backend/manager/modules
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Fix double ownership of backups directory.
..
packaging: Fix double ownership of backups directory.
Currently rpm installation of ovirt on f
Juan Hernandez has posted comments on this change.
Change subject: packaging: Fix double ownership of backups directory.
..
Patch Set 3: Verified; Looks good to me, approved
Merging based on previous acks and verification.
--
Juan Hernandez has posted comments on this change.
Change subject: packaging: Fix double ownership of backups directory.
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9216
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: Adding system information to getCapabilities from host
..
Patch Set 1: I would prefer that you didn't submit this
(5 inline comments)
.
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 11:
I just think that the java tools are great, but there is a room for more
Yair Zaslavsky has posted comments on this change.
Change subject: Adding system information to getCapabilities from host
..
Patch Set 1:
Michael - do we need to expose this via Rest-API?
Yaniv, Can you add a bit more at the co
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Added null check to avoid NPE
..
engine: Added null check to avoid NPE
If the qualified brick name is not available in the brick list,
may th
Omer Frenkel has posted comments on this change.
Change subject: engine: Added null check to avoid NPE
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9117
To unsubscribe, visit ht
Omer Frenkel has posted comments on this change.
Change subject: engine: Added null check to avoid NPE
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9117
To unsubscribe, visit http://gerri
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: change handling of sysctl.conf
..
packaging: change handling of sysctl.conf
in fedora 18 the location of /etc/sysctl.conf had changed to
/us
Juan Hernandez has posted comments on this change.
Change subject: packaging: change handling of sysctl.conf
..
Patch Set 12: Verified; Looks good to me, approved
Merging based on previous acks and verification.
--
To view, vi
Juan Hernandez has posted comments on this change.
Change subject: packaging: change handling of sysctl.conf
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8705
To unsubscribe, visit http:
Yair Zaslavsky has submitted this change and it was merged.
Change subject: utils: tar: split tar unit test from VdsInstallerSSH tests.
..
utils: tar: split tar unit test from VdsInstallerSSH tests.
VdsInstallerSSH.java is abou
Yair Zaslavsky has posted comments on this change.
Change subject: utils: tar: split tar unit test from VdsInstallerSSH tests.
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9292
Yair Zaslavsky has posted comments on this change.
Change subject: utils: tar: split tar unit test from VdsInstallerSSH tests.
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/9292
To unsubscribe, visit http:/
Yair Zaslavsky has posted comments on this change.
Change subject: utils: tar: split tar unit test from VdsInstallerSSH tests.
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9292
To unsubsc
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Added null check to avoid NPE
..
Patch Set 2: Verified
Rebased
--
To view, visit http://gerrit.ovirt.org/9117
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: Default disk aliases when reading OVFs
..
Patch Set 2: I would prefer that you didn't submit this
rebased, no code changes - please do not merge until mku
Allon Mureinik has posted comments on this change.
Change subject: core: OvfReader cleanup - remove unused parameter
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes - echoing previous +2 review.
-
Allon Mureinik has posted comments on this change.
Change subject: core: OvfReader cleanup - correct DiskImage method
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9306
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: OvfReader cleanup - correct DiskImage method
..
Patch Set 2: Looks good to me, but someone else must approve
Rebased, no code changes - echoing previous +
Allon Mureinik has posted comments on this change.
Change subject: core: OvfReader cleanup - remove StringHelper
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes - echoing previous +2.
--
To view,
Allon Mureinik has posted comments on this change.
Change subject: core: Extract disk alias generation methods
..
Patch Set 5:
pushed new version without noticing mlipchuks and laravot's review - will
address in next patchset.
Allon Mureinik has posted comments on this change.
Change subject: core: OvfReader cleanup - document empty blocks
..
Patch Set 2: Verified
addressed Vered's and Roy's comments.
--
To view, visit http://gerrit.ovirt.org/9304
T
1 - 100 of 134 matches
Mail list logo
