Vered Volansky has posted comments on this change. Change subject: core:WIP: introducing OvfAutoUpdate ......................................................................
Patch Set 3: (5 inline comments) .................................................... Commit Message Line 13: vms/templates - update, save, adding/removing a disk, etc. What's more, Line 14: currently updating the ovf (updateVM vdsm call) is usually done within a Line 15: transcation. Line 16: Line 17: The idea behined OvfAutoUpdater is to perform batch ovf update perform A batch Line 18: operations that aggregate all outstanding updates per data center. These Line 19: updates will be done in specifed time intervals which will reduce Line 20: XML-RPC calls and will enable the removal of this syncronous vdsm call Line 21: from all over the code. Line 14: currently updating the ovf (updateVM vdsm call) is usually done within a Line 15: transcation. Line 16: Line 17: The idea behined OvfAutoUpdater is to perform batch ovf update Line 18: operations that aggregate all outstanding updates per data center. These s/outstanding/hanging. I think you meant upstanding, but that's also not exactly right. Line 19: updates will be done in specifed time intervals which will reduce Line 20: XML-RPC calls and will enable the removal of this syncronous vdsm call Line 21: from all over the code. Line 22: Line 20: XML-RPC calls and will enable the removal of this syncronous vdsm call Line 21: from all over the code. Line 22: Line 23: known issues that will be addressed: Line 24: 1. Unite the operations of vm template ovf update/ vm update to single to A single Line 25: vdsm command execution. Line 26: 2. remove updateVmInSpm/updateVmTemplateInSpm from Line 27: VmTemplateCommand/VmCommand Line 28: 3. Remove call to this methods from all calling commands while updating Line 24: 1. Unite the operations of vm template ovf update/ vm update to single Line 25: vdsm command execution. Line 26: 2. remove updateVmInSpm/updateVmTemplateInSpm from Line 27: VmTemplateCommand/VmCommand Line 28: 3. Remove call to this methods from all calling commands while updating Remove THE call, s/this/these Line 29: the vm/template update date instead. Line 30: 4. log prints Line 31: 5. tests Line 32: 6. remove duplicate methods from vm dao/vm template dao - currently Line 30: 4. log prints Line 31: 5. tests Line 32: 6. remove duplicate methods from vm dao/vm template dao - currently Line 33: some methods are implemented for both though they can be implemented for Line 34: vmstatic only. it was implemented like this at the moment in order to s/was/is Line 35: avoid different implementation than how's it currently implemented for Line 36: other methods. Line 37: Line 38: Change-Id: I9b5132300fb1f1fd94f771cab15efe5246dbeca8 -- To view, visit http://gerrit.ovirt.org/9328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b5132300fb1f1fd94f771cab15efe5246dbeca8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
