Sharad Mishra has posted comments on this change. Change subject: core: correcting max memory for scheduling VMs field ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java Line 862: return mVdsDynamic.getpending_vmem_size(); Line 863: } Line 864: Line 865: public void setpending_vmem_size(int value) { Line 866: mVdsDynamic.setpending_vmem_size(value); input parameter of 'value' should change from 'int' to "Integer' and VDSDynamic.java need to be updated to reflect this change. Line 867: } Line 868: Line 869: public Boolean getnet_config_dirty() { Line 870: return mVdsDynamic.getnet_config_dirty(); -- To view, visit http://gerrit.ovirt.org/8367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7be5683f2ae708dff7f59bba194b3ea05935bcc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amador Pahim <apa...@redhat.com> Gerrit-Reviewer: Amador Pahim <apa...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches