Maor Lipchuk has posted comments on this change.
Change subject: core: Extract disk alias generation methods
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/disks/DiskUtilsTest.java
Line 29:
Line 30: @Test
Line 31: public void testNullAliasDisk() {
Line 32: disk.setDiskAlias(null);
Line 33: assertEquals("null disk does not give the default name",
perhaps you meant to write "Disk with null alias, does not generates the
default disk name"
Line 34: prefix + "_Disk1",
Line 35: DiskUtils.getSuggestedDiskAlias(disk, prefix, 1));
Line 36: }
Line 37:
Line 37:
Line 38: @Test
Line 39: public void testNotNullAliasDisk() {
Line 40: disk.setDiskAlias("someAlias");
Line 41: assertEquals("null disk does not give the default name",
Not relevant message for this specific test.
Line 42: disk.getDiskAlias(),
Line 43: DiskUtils.getSuggestedDiskAlias(disk, prefix, 1));
Line 44: }
--
To view, visit http://gerrit.ovirt.org/9273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf2a1147c022f4cdb7c5658818667af4b51e6aac
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
