Yair Zaslavsky has posted comments on this change. Change subject: Adding system information to getCapabilities from host ......................................................................
Patch Set 1: I would prefer that you didn't submit this (5 inline comments) .................................................... File backend/manager/dbscripts/create_tables.sql Line 432: CREATE TABLE vds_dynamic Line 433: ( Line 434: vds_id UUID NOT NULL, Line 435: status INTEGER NOT NULL, Line 436: host_manufacturer VARCHAR(40), This is not how it's done, you need to add an upgrade script. The reason is that create_db_devel runs create_tables.sql to create the "base" + upgrade scripts (which were added during working on features). However, if I want just to upgrade (using upgrade.sh ) I will run only the scripts at the upgrade directory (I cannot run create table sql statmenet again). Line 437: host_product_name VARCHAR(40), Line 438: host_version VARCHAR(40), Line 439: host_serial_number VARCHAR(40), Line 440: host_uuid VARCHAR(40), .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java Line 157: return true; Line 158: } Line 159: Line 160: public VDS(Guid vds_group_id, String vds_group_name, String vds_group_description, Guid vds_id, String vds_name, Line 161: String ip, String host_name, int port, int status, String host_manufacturer, String host_product_name, One day someone will fix all the non java parameters and we will all be Happy . I know currently this will involve two coding conventions (old , bad C# , non java + new java convention) , but please - host_manuFacturer -> hostManufacturer and so on. bare in mind this must effect your setters + getters methods. Line 162: String host_version, String host_serial_number, String host_uuid, String host_family, Line 163: Integer cpu_cores, String cpu_model, Line 164: Double cpu_speed_mh, String if_total_speed, Boolean kvm_enabled, Integer physical_mem_mb, Line 165: Double cpu_idle, Double cpu_load, Double cpu_sys, .................................................... File backend/manager/modules/dal/src/test/resources/fixtures.xml Line 1234: Line 1235: <table name="vds_dynamic"> Line 1236: <column>vds_id</column> Line 1237: <column>status</column> Line 1238: <column>host_manufacturer</column> Added whitespaces, please remove Line 1239: <column>host_product_name</column> Line 1240: <column>host_version</column> Line 1241: <column>host_serial_number</column> Line 1242: <column>host_uuid</column> .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java Line 303: vds.sethost_manufacturer(AssignStringValue(xmlRpcStruct, VdsProperties.host_manufacturer)); Line 304: vds.sethost_product_name(AssignStringValue(xmlRpcStruct, VdsProperties.host_product_name)); Line 305: vds.sethost_version(AssignStringValue(xmlRpcStruct, VdsProperties.host_version)); Line 306: vds.sethost_serial_number(AssignStringValue(xmlRpcStruct, VdsProperties.host_serial_number)); Line 307: vds.sethost_uuid(AssignStringValue(xmlRpcStruct, VdsProperties.host_uuid)); Please fix the naming convention for your added constants at VdsProperties Line 308: vds.sethost_family(AssignStringValue(xmlRpcStruct, VdsProperties.host_family)); Line 309: vds.setcpu_cores(AssignIntValue(xmlRpcStruct, VdsProperties.cpu_cores)); Line 310: vds.setcpu_sockets(AssignIntValue(xmlRpcStruct, VdsProperties.cpu_sockets)); Line 311: vds.setcpu_model(AssignStringValue(xmlRpcStruct, VdsProperties.cpu_model)); .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java Line 26: Line 27: public static final String SpiceSecureChannels = "spiceSecureChannels"; Line 28: public static final String host_manufacturer = "hostManufacturer"; Line 29: public static final String host_product_name = "hostProductName"; Line 30: public static final String host_version = "hostVersion"; What does "hostVersion" represent? You see why we need a Wiki?:) I got confused with vdsmVersion! Line 31: public static final String host_serial_number = "hostSerialNumber"; Line 32: public static final String host_uuid = "hostUUID"; Line 33: public static final String host_family = "hostFamily"; Line 34: public static final String cpu_cores = "cpuCores"; -- To view, visit http://gerrit.ovirt.org/9337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
