Sharad Mishra has posted comments on this change. Change subject: core: Extract disk alias generation methods ......................................................................
Patch Set 5: Looks good to me, but someone else must approve (1 inline comment) .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/disks/DiskUtils.java Line 25: * Line 26: * @param disk Line 27: * - The disk that (possibly) requires a new alias Line 28: * @param diskPrefix Line 29: * - The prefix for the newly generated alias include count Line 30: * @return The suggested alias Line 31: */ Line 32: public static String getSuggestedDiskAlias(BaseDisk disk, String diskPrefix, int count) { Line 33: String diskAlias; -- To view, visit http://gerrit.ovirt.org/9273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf2a1147c022f4cdb7c5658818667af4b51e6aac Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches