Juan Hernandez has posted comments on this change. Change subject: bootstrap: use LocalConfig for engine http host and port ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java Line 176: String.format( Line 177: "http://%1$s:%2$s/Components/vds/";, Line 178: LocalConfig.getInstance().getHost(), Line 179: LocalConfig.getInstance().getExternalHttpPort() Line 180: ) LocalConfig.getInstance().getExternalHttpUrl() + "/Components/vds/" Line 181: ); Line 182: initialCommand = initialCommand.replace("{GUID}", _fileGuid.toString()); Line 183: initialCommand = initialCommand.replace("{server_SSL_enabled}", Line 184: Config.<Boolean> GetValue(ConfigValues.UseSecureConnectionWithServers).toString()); Line 188: initialCommand = initialCommand.replace( Line 189: "{EnginePort}", Line 190: String.format( Line 191: "-p %1$s", Line 192: LocalConfig.getInstance().getExternalHttpsPort() This used to be HTTP, so it should now be LocalConfig.getInstance().getExternalHttpPort(). Line 193: ) Line 194: ); Line 195: Line 196: initialCommand = initialCommand.replace("{SSHKey}", _remoteSSHKey); -- To view, visit http://gerrit.ovirt.org/9368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01cd66cd83356c4dbaa0bae35ed0fe83c7c00852 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
