Shireesh Anjal has posted comments on this change.
Change subject: gluster: replace VdsInstallerSSH: with the SSHDialog
..
Patch Set 3: (1 inline comment)
File
backend/manag
Yair Zaslavsky has posted comments on this change.
Change subject: pki: cleanup the ca interface
..
Patch Set 4: Looks good to me, but someone else must approve
Alon - if you want to make code cleaner + avoid typos in this case
Yair Zaslavsky has posted comments on this change.
Change subject: pki: accept subject name for certificate
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9163
To unsub
Yair Zaslavsky has posted comments on this change.
Change subject: utils: tar: support long file names within tar
..
Patch Set 4: Looks good to me, but someone else must approve
Waiting for package change, besides that +1 on ad
Yair Zaslavsky has posted comments on this change.
Change subject: utils: tar: throw an exception if base does not exist
..
Patch Set 4:
Shouldn't this move to the tar package we talked about as well?
--
To view, visit http://
Yair Zaslavsky has posted comments on this change.
Change subject: utils: move Tar, CachedTar classes to own package
..
Patch Set 2: Looks good to me, approved
Thanks for the package change
--
To view, visit http://gerrit.ovir
Yair Zaslavsky has posted comments on this change.
Change subject: utils: tests: tar: cleanup main() entry point
..
Patch Set 4:
I'll correct myself - "this is how things should be done in Java development" :)
I don't need to e
Yair Zaslavsky has posted comments on this change.
Change subject: utils: tests: tar: cleanup main() entry point
..
Patch Set 4:
Alon,
Regarding your question - this is things are done in Java development.
I must say, that as s
Yair Zaslavsky has posted comments on this change.
Change subject: utils: tests: do not use default key alias
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9167
To unsubscribe, visit http:
Yair Zaslavsky has posted comments on this change.
Change subject: utils: tests: do not use default key alias
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9167
To uns
Yair Zaslavsky has posted comments on this change.
Change subject: utils: ssh: don't add ssh command to exception
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9168
To unsubscribe, visit h
Yair Zaslavsky has posted comments on this change.
Change subject: utils: ssh: fixup activity detection
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9169
To unsubscribe, visit http://gerr
Yair Zaslavsky has posted comments on this change.
Change subject: utils: ssh: optimize progress streams
..
Patch Set 4:
Regarding package changing - not yet, but someone might want to to use it.
I actually once needed a "Progr
Yair Zaslavsky has posted comments on this change.
Change subject: utils: ssh: move to member '_' convention
..
Patch Set 4: Looks good to me, but someone else must approve
+1 on code issue + we need to push this series of patc
Yair Zaslavsky has posted comments on this change.
Change subject: utils: ssh: cleanup: rename server with host
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9246
To unsubscribe, visit htt
Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: host add: differentiate between authentication error
and other errors
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, vi
Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: split the logic of ovirt-node upgrade out
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: split the logic of ovirt-node upgrade out
..
Patch Set 5: Verified
Rebase.
--
To view, visit http://gerrit.ovirt.org/9172
To unsubscribe, visit http:/
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh: cleanup: rename server with host
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9246
To unsubscribe, visit http://gerrit.ovirt.org
Alon Bar-Lev has posted comments on this change.
Change subject: utils: move Tar, CachedTar classes to own package
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9245
To unsubscribe, visit http://gerrit.ovir
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: host add: differentiate between authentication error
and other errors
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/9178
To unsub
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: handle bootstrap messages using string member
..
Patch Set 5: Verified
Rebase.
--
To view, visit http://gerrit.ovirt.org/9173
To unsubscribe, visit ht
Alon Bar-Lev has posted comments on this change.
Change subject: utils: tests: do not use default key alias
..
Patch Set 4: Verified
Rebase.
--
To view, visit http://gerrit.ovirt.org/9167
To unsubscribe, visit http://gerrit.ov
Alon Bar-Lev has posted comments on this change.
Change subject: utils: tests: tar: cleanup main() entry point
..
Patch Set 4: Verified
Rebase.
--
To view, visit http://gerrit.ovirt.org/9166
To unsubscribe, visit http://gerrit
Alon Bar-Lev has posted comments on this change.
Change subject: utils: tar: throw an exception if base does not exist
..
Patch Set 4: Verified
Rebase.
--
To view, visit http://gerrit.ovirt.org/9165
To unsubscribe, visit http:
Alon Bar-Lev has posted comments on this change.
Change subject: utils: tar: support long file names within tar
..
Patch Set 4: Verified
Rebase.
--
To view, visit http://gerrit.ovirt.org/9164
To unsubscribe, visit http://gerri
Alon Bar-Lev has posted comments on this change.
Change subject: pki: accept subject name for certificate
..
Patch Set 4: Verified
Rebase.
--
To view, visit http://gerrit.ovirt.org/9163
To unsubscribe, visit http://gerrit.ovir
Alon Bar-Lev has posted comments on this change.
Change subject: pki: cleanup the ca interface
..
Patch Set 4: Verified
Rebase.
--
To view, visit http://gerrit.ovirt.org/9162
To unsubscribe, visit http://gerrit.ovirt.org/setti
Alon Bar-Lev has posted comments on this change.
Change subject: gluster: replace VdsInstallerSSH: with the SSHDialog
..
Patch Set 6:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9160
To unsubscribe, visit http://gerrit.o
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: allow distinguish error from non error messages
..
Patch Set 5: No score
Cleanups, sorry.
--
To view, visit http://gerrit.ovirt.org/9161
To unsubscrib
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: allow distinguish error from non error messages
..
Patch Set 5: Verified
Rebase.
--
To view, visit http://gerrit.ovirt.org/9161
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: do not get unique id at canDoAction
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9159
To unsubscribe, visit http://gerrit.ovirt.o
Alon Bar-Lev has posted comments on this change.
Change subject: registration: fix null pointer exception
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9158
To unsubscribe, visit http://gerrit.ovirt.org/set
Einav Cohen has posted comments on this change.
Change subject: bootstrap: host add: differentiate between authentication error
and other errors
..
Patch Set 6: Looks good to me, but someone else must approve
- no change in me
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: do not check connectivity nor unique id when
VdsInstall=false
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9157
To unsubscribe,
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: fix ovirt-node parameters and locations
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9156
To unsubscribe, visit http://gerrit.ovi
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh: move to member '_' convention
..
Patch Set 4: Verified
Rebase.
--
To view, visit http://gerrit.ovirt.org/9171
To unsubscribe, visit http://gerrit.ovi
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh: optimize progress streams
..
Patch Set 4: Verified
Rebase.
--
To view, visit http://gerrit.ovirt.org/9170
To unsubscribe, visit http://gerrit.ovirt.o
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh: fixup activity detection
..
Patch Set 4: Verified
Rebased.
--
To view, visit http://gerrit.ovirt.org/9169
To unsubscribe, visit http://gerrit.ovirt.o
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: handle bootstrap messages using string member
..
Patch Set 4: Verified
Rebase.
--
To view, visit http://gerrit.ovirt.org/9173
To unsubscribe, visit ht
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: split the logic of ovirt-node upgrade out
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/9172
To unsubscribe, visit http://gerrit.o
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: split the logic of ovirt-node upgrade out
..
Patch Set 4:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9172
To unsubscribe, visit http://gerrit.o
Alon Bar-Lev has posted comments on this change.
Change subject: core: Event log - a method to bypass flow
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
Rebase.
--
To view, visit http://gerrit.ovirt
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh: don't add ssh command to exception
..
Patch Set 4: Verified
Rebase.
--
To view, visit http://gerrit.ovirt.org/9168
To unsubscribe, visit http://gerri
Sharad Mishra has posted comments on this change.
Change subject: engine: Fixed message when trying to move a locked disk.
..
Patch Set 1: I would prefer that you didn't submit this
look at http://gerrit.ovirt.org/#/c/8693/
--
Moran Goldboim has posted comments on this change.
Change subject: packaging: Updated allinone plugin for new security mode
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated allinone plugin for new security mode
..
Patch Set 1:
Yes, I built new packages from the branch and installed the all in one plugin.
--
To v
Sharad Mishra has posted comments on this change.
Change subject: bootstrap: host add: differentiate between authentication error
and other errors
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, vis
Asaf Shakarchi has uploaded a new change for review.
Change subject: engine: Fixed message when trying to move a locked disk.
..
engine: Fixed message when trying to move a locked disk.
When trying to move a locked disk, the fol
Sharad Mishra has posted comments on this change.
Change subject: engine: Clean up of exceptions
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9267
To unsubscribe, vis
Liron Aravot has posted comments on this change.
Change subject: core: Fix error message for locked disks
..
Patch Set 11: (1 inline comment)
Commit Message
Line 8:
Line 9:
Moran Goldboim has posted comments on this change.
Change subject: packaging: Updated allinone plugin for new security mode
..
Patch Set 1:
Juan, have you verified it on top of 3.1 branch?
--
To view, visit http://gerrit.ovirt
Sharad Mishra has posted comments on this change.
Change subject: core: Fix error message for locked disks
..
Patch Set 11:
Should the message be changed from "The following disks are locked:" to "The
following disk(s) are loc
Yaniv Dary has posted comments on this change.
Change subject: packaging: fixed setup issues (#876240\876242)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9277
To unsubscribe, v
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: fixed setup issues (#876240\876242)
..
packaging: fixed setup issues (#876240\876242)
- made etl run always with the ovirt engine java version.
Yaniv Dary has uploaded a new change for review.
Change subject: packaging: fixed setup issues (#876240\876242)
..
packaging: fixed setup issues (#876240\876242)
- made etl run always with the ovirt engine java version.
- fixed
Allon Mureinik has posted comments on this change.
Change subject: core: Extract disk alias generation methods
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/9273
To unsubscribe, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
..
Patch Set 5: (1 inline comment)
File
backend/man
Allon Mureinik has uploaded a new change for review.
Change subject: core: Extract disk alias generation methods
..
core: Extract disk alias generation methods
Extracted the methods used to generate disk alias from ImagesHandler
Barak Azulay has posted comments on this change.
Change subject: restapi: API should expose hypervisor version (#829625)
..
Patch Set 3: (1 inline comment)
File
backend/mana
Allon Mureinik has posted comments on this change.
Change subject: core: libosinfo - introduce libosinfo service
..
Patch Set 8: I would prefer that you didn't submit this
(10 inline comments)
-1 given since the tests won't pa
Ravi Nori has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
..
Patch Set 5: (1 inline comment)
File
backend/manager/
Juan Hernandez has posted comments on this change.
Change subject: core: Update the commons-lang 2.6
..
Patch Set 1: Verified
Not much to verify, just that the build and the tests works, as we are already
using version 2.6 in
Juan Hernandez has uploaded a new change for review.
Change subject: core: Update the commons-lang 2.6
..
core: Update the commons-lang 2.6
This is the version that we are using in deployments as it is included
in Fedora, just n
Juan Hernandez has posted comments on this change.
Change subject: webadmin: UI Plugins PoC, revision 7
..
Patch Set 2: (2 inline comments)
File
frontend/webadmin/modules/fr
Vered Volansky has posted comments on this change.
Change subject: core: Fix error message for locked disks
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/8693
To unsubscribe, visit http://gerrit.ovirt.org/
Yair Zaslavsky has abandoned this change.
Change subject: core: Introducing update of vdsm task ID at Db
..
Patch Set 1: Abandoned
Not needed - will be handled by next patches -
--
To view, visit http://gerrit.ovirt.org/9257
T
Michael Kublin has posted comments on this change.
Change subject: engine: Clean up of exceptions
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9267
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Michael Kublin has posted comments on this change.
Change subject: engine: Removed duplicate retrieve of vdsm task, during SPM
election
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9266
To unsubscribe, vi
Michael Kublin has uploaded a new change for review.
Change subject: engine: Removed duplicate retrieve of vdsm task, during SPM
election
..
engine: Removed duplicate retrieve of vdsm task, during SPM election
The following fix
Michael Kublin has uploaded a new change for review.
Change subject: engine: Clean up of exceptions
..
engine: Clean up of exceptions
The following patch is removing unneeded exceptions, unneeded catch of
exceptions,
unneeded c
ofri masad has posted comments on this change.
Change subject: core: Quota refactor
..
Patch Set 7: (7 inline comments)
File
backend/manager/modules/bll/src/main/java/org/ov
Vered Volansky has posted comments on this change.
Change subject: webadmin: NPE fix when adding a domain (#856583)
..
Patch Set 3: Verified
Just removed a dependency that shouldn't have been here.
--
To view, visit http://ger
Vered Volansky has posted comments on this change.
Change subject: webadmin: NPE fix when adding a domain (#856583)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9259
To unsubscribe, visit http://gerrit.ovi
Muli Salem has submitted this change and it was merged.
Change subject: webadmin: Network main tab is not visible in some tree
selections.
..
webadmin: Network main tab is not visible in some tree selections.
Network Main Tab
Muli Salem has posted comments on this change.
Change subject: webadmin: Network main tab is not visible in some tree
selections.
..
Patch Set 12: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/
Daniel Erez has posted comments on this change.
Change subject: webadmin: Network main tab is not visible in some tree
selections.
..
Patch Set 12: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9077
To u
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Network main tab is not visible in some tree
selections.
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerr
Muli Salem has submitted this change and it was merged.
Change subject: engine: Add Network Search for Host Name
..
engine: Add Network Search for Host Name
This patch adds the network_vds_view, to be used by
the tree search fo
Muli Salem has posted comments on this change.
Change subject: engine: Add Network Search for Host Name
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9265
To unsubscribe, visit h
Muli Salem has submitted this change and it was merged.
Change subject: engine: Add Vds Port Validation 65535 (#871328)
..
engine: Add Vds Port Validation 65535 (#871328)
This patch changes the maximum port number to
65535 usin
Muli Salem has posted comments on this change.
Change subject: engine: Add Vds Port Validation 65535 (#871328)
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9149
To unsubscribe,
Moti Asayag has posted comments on this change.
Change subject: engine: Add Network Search for Host Name
..
Patch Set 3: Looks good to me, approved
(1 inline comment)
File b
Muli Salem has submitted this change and it was merged.
Change subject: engine: Add Network Search for Cluster Name
..
engine: Add Network Search for Cluster Name
This patch adds the cluster name column to network_cluster_view.
Muli Salem has posted comments on this change.
Change subject: engine: Add Network Search for Cluster Name
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9155
To unsubscribe, visi
Vered Volansky has posted comments on this change.
Change subject: core: Fix error message for locked disks
..
Patch Set 10:
Patch set 10 was submitted by mistake, Please ignore.
--
To view, visit http://gerrit.ovirt.org/8693
Muli Salem has posted comments on this change.
Change subject: engine: Add Network Search for Host Name
..
Patch Set 1: (2 inline comments)
File
backend/manager/modules/sear
Eli Mesika has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
..
Patch Set 5: (2 inline comments)
File backend/manager
Ravi Nori has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
..
Patch Set 5: (1 inline comment)
File backend/manager/d
Roy Golan has posted comments on this change.
Change subject: core: libosinfo - Use libosinfoService to validate memory values
..
Patch Set 8: (1 inline comment)
Commit Messa
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/2187/
Build Number: 2187
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Moti Asayag has posted comments on this change.
Change subject: webadmin: Network main tab is not visible in some tree
selections.
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerri
Moti Asayag has posted comments on this change.
Change subject: engine: Add Network Search for Host Name
..
Patch Set 1: (2 inline comments)
File
backend/manager/modules/sea
Muli Salem has posted comments on this change.
Change subject: webadmin: Network main tab is not visible in some tree
selections.
..
Patch Set 9: (1 inline comment)
File
fr
Shireesh Anjal has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 3: (1 inline comment)
Moti Asayag has posted comments on this change.
Change subject: engine: Add Network Search for Cluster Name
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9155
To unsubscribe, visit http://
Moti Asayag has posted comments on this change.
Change subject: webadmin: Network main tab is not visible in some tree
selection.
..
Patch Set 9: (2 inline comments)
Commit
Maor Lipchuk has posted comments on this change.
Change subject: [WIP] core: Distingushing between entity and vdsm task ids
..
Patch Set 4: (3 inline comments)
File
backend/
Muli Salem has uploaded a new change for review.
Change subject: engine: Add Network Search for Host Name
..
engine: Add Network Search for Host Name
This patch adds the network_vds_view, to be used by
the tree search for Networ
Selvasundaram has posted comments on this change.
Change subject: engine: Gluster Volume Georeplication Stop
..
Patch Set 4: (1 inline comment)
AuditLog messages added
File
1 - 100 of 154 matches
Mail list logo