[Engine-patches] Change in ovirt-engine[master]: gluster: replace VdsInstallerSSH: with the SSHDialog

2012-11-15 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: gluster: replace VdsInstallerSSH: with the SSHDialog .. Patch Set 3: (1 inline comment) File backend/manag

[Engine-patches] Change in ovirt-engine[master]: pki: cleanup the ca interface

2012-11-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: pki: cleanup the ca interface .. Patch Set 4: Looks good to me, but someone else must approve Alon - if you want to make code cleaner + avoid typos in this case

[Engine-patches] Change in ovirt-engine[master]: pki: accept subject name for certificate

2012-11-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: pki: accept subject name for certificate .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9163 To unsub

[Engine-patches] Change in ovirt-engine[master]: utils: tar: support long file names within tar

2012-11-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: utils: tar: support long file names within tar .. Patch Set 4: Looks good to me, but someone else must approve Waiting for package change, besides that +1 on ad

[Engine-patches] Change in ovirt-engine[master]: utils: tar: throw an exception if base does not exist

2012-11-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: utils: tar: throw an exception if base does not exist .. Patch Set 4: Shouldn't this move to the tar package we talked about as well? -- To view, visit http://

[Engine-patches] Change in ovirt-engine[master]: utils: move Tar, CachedTar classes to own package

2012-11-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: utils: move Tar, CachedTar classes to own package .. Patch Set 2: Looks good to me, approved Thanks for the package change -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: utils: tests: tar: cleanup main() entry point

2012-11-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: utils: tests: tar: cleanup main() entry point .. Patch Set 4: I'll correct myself - "this is how things should be done in Java development" :) I don't need to e

[Engine-patches] Change in ovirt-engine[master]: utils: tests: tar: cleanup main() entry point

2012-11-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: utils: tests: tar: cleanup main() entry point .. Patch Set 4: Alon, Regarding your question - this is things are done in Java development. I must say, that as s

[Engine-patches] Change in ovirt-engine[master]: utils: tests: do not use default key alias

2012-11-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: utils: tests: do not use default key alias .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9167 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: utils: tests: do not use default key alias

2012-11-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: utils: tests: do not use default key alias .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9167 To uns

[Engine-patches] Change in ovirt-engine[master]: utils: ssh: don't add ssh command to exception

2012-11-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: utils: ssh: don't add ssh command to exception .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9168 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: utils: ssh: fixup activity detection

2012-11-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: utils: ssh: fixup activity detection .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9169 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: utils: ssh: optimize progress streams

2012-11-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: utils: ssh: optimize progress streams .. Patch Set 4: Regarding package changing - not yet, but someone might want to to use it. I actually once needed a "Progr

[Engine-patches] Change in ovirt-engine[master]: utils: ssh: move to member '_' convention

2012-11-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: utils: ssh: move to member '_' convention .. Patch Set 4: Looks good to me, but someone else must approve +1 on code issue + we need to push this series of patc

[Engine-patches] Change in ovirt-engine[master]: utils: ssh: cleanup: rename server with host

2012-11-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: utils: ssh: cleanup: rename server with host .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9246 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: bootstrap: host add: differentiate between authentication er...

2012-11-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: bootstrap: host add: differentiate between authentication error and other errors .. Patch Set 6: Looks good to me, but someone else must approve -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: bootstrap: split the logic of ovirt-node upgrade out

2012-11-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: bootstrap: split the logic of ovirt-node upgrade out .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9

[Engine-patches] Change in ovirt-engine[master]: bootstrap: split the logic of ovirt-node upgrade out

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: split the logic of ovirt-node upgrade out .. Patch Set 5: Verified Rebase. -- To view, visit http://gerrit.ovirt.org/9172 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: utils: ssh: cleanup: rename server with host

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: ssh: cleanup: rename server with host .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/9246 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: utils: move Tar, CachedTar classes to own package

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: move Tar, CachedTar classes to own package .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/9245 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: bootstrap: host add: differentiate between authentication er...

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: host add: differentiate between authentication error and other errors .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/9178 To unsub

[Engine-patches] Change in ovirt-engine[master]: bootstrap: handle bootstrap messages using string member

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: handle bootstrap messages using string member .. Patch Set 5: Verified Rebase. -- To view, visit http://gerrit.ovirt.org/9173 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: utils: tests: do not use default key alias

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: tests: do not use default key alias .. Patch Set 4: Verified Rebase. -- To view, visit http://gerrit.ovirt.org/9167 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: utils: tests: tar: cleanup main() entry point

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: tests: tar: cleanup main() entry point .. Patch Set 4: Verified Rebase. -- To view, visit http://gerrit.ovirt.org/9166 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: utils: tar: throw an exception if base does not exist

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: tar: throw an exception if base does not exist .. Patch Set 4: Verified Rebase. -- To view, visit http://gerrit.ovirt.org/9165 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: utils: tar: support long file names within tar

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: tar: support long file names within tar .. Patch Set 4: Verified Rebase. -- To view, visit http://gerrit.ovirt.org/9164 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: pki: accept subject name for certificate

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: pki: accept subject name for certificate .. Patch Set 4: Verified Rebase. -- To view, visit http://gerrit.ovirt.org/9163 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: pki: cleanup the ca interface

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: pki: cleanup the ca interface .. Patch Set 4: Verified Rebase. -- To view, visit http://gerrit.ovirt.org/9162 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: gluster: replace VdsInstallerSSH: with the SSHDialog

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: gluster: replace VdsInstallerSSH: with the SSHDialog .. Patch Set 6: Rebase. -- To view, visit http://gerrit.ovirt.org/9160 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: bootstrap: allow distinguish error from non error messages

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: allow distinguish error from non error messages .. Patch Set 5: No score Cleanups, sorry. -- To view, visit http://gerrit.ovirt.org/9161 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: bootstrap: allow distinguish error from non error messages

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: allow distinguish error from non error messages .. Patch Set 5: Verified Rebase. -- To view, visit http://gerrit.ovirt.org/9161 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: bootstrap: do not get unique id at canDoAction

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: do not get unique id at canDoAction .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/9159 To unsubscribe, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: registration: fix null pointer exception

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: registration: fix null pointer exception .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/9158 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: bootstrap: host add: differentiate between authentication er...

2012-11-15 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: bootstrap: host add: differentiate between authentication error and other errors .. Patch Set 6: Looks good to me, but someone else must approve - no change in me

[Engine-patches] Change in ovirt-engine[master]: bootstrap: do not check connectivity nor unique id when VdsI...

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: do not check connectivity nor unique id when VdsInstall=false .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/9157 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: bootstrap: fix ovirt-node parameters and locations

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: fix ovirt-node parameters and locations .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/9156 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: utils: ssh: move to member '_' convention

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: ssh: move to member '_' convention .. Patch Set 4: Verified Rebase. -- To view, visit http://gerrit.ovirt.org/9171 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: utils: ssh: optimize progress streams

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: ssh: optimize progress streams .. Patch Set 4: Verified Rebase. -- To view, visit http://gerrit.ovirt.org/9170 To unsubscribe, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: utils: ssh: fixup activity detection

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: ssh: fixup activity detection .. Patch Set 4: Verified Rebased. -- To view, visit http://gerrit.ovirt.org/9169 To unsubscribe, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: bootstrap: handle bootstrap messages using string member

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: handle bootstrap messages using string member .. Patch Set 4: Verified Rebase. -- To view, visit http://gerrit.ovirt.org/9173 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: bootstrap: split the logic of ovirt-node upgrade out

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: split the logic of ovirt-node upgrade out .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/9172 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: bootstrap: split the logic of ovirt-node upgrade out

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: split the logic of ovirt-node upgrade out .. Patch Set 4: Rebase. -- To view, visit http://gerrit.ovirt.org/9172 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: Event log - a method to bypass flow

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: Event log - a method to bypass flow .. Patch Set 5: Verified; Looks good to me, but someone else must approve Rebase. -- To view, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: utils: ssh: don't add ssh command to exception

2012-11-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: ssh: don't add ssh command to exception .. Patch Set 4: Verified Rebase. -- To view, visit http://gerrit.ovirt.org/9168 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: engine: Fixed message when trying to move a locked disk.

2012-11-15 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: engine: Fixed message when trying to move a locked disk. .. Patch Set 1: I would prefer that you didn't submit this look at http://gerrit.ovirt.org/#/c/8693/ --

[Engine-patches] Change in ovirt-engine[engine_3.1]: packaging: Updated allinone plugin for new security mode

2012-11-15 Thread mgoldboi
Moran Goldboim has posted comments on this change. Change subject: packaging: Updated allinone plugin for new security mode .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[engine_3.1]: packaging: Updated allinone plugin for new security mode

2012-11-15 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Updated allinone plugin for new security mode .. Patch Set 1: Yes, I built new packages from the branch and installed the all in one plugin. -- To v

[Engine-patches] Change in ovirt-engine[master]: bootstrap: host add: differentiate between authentication er...

2012-11-15 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: bootstrap: host add: differentiate between authentication error and other errors .. Patch Set 4: Looks good to me, but someone else must approve -- To view, vis

[Engine-patches] Change in ovirt-engine[master]: engine: Fixed message when trying to move a locked disk.

2012-11-15 Thread asaf
Asaf Shakarchi has uploaded a new change for review. Change subject: engine: Fixed message when trying to move a locked disk. .. engine: Fixed message when trying to move a locked disk. When trying to move a locked disk, the fol

[Engine-patches] Change in ovirt-engine[master]: engine: Clean up of exceptions

2012-11-15 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: engine: Clean up of exceptions .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9267 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: Fix error message for locked disks

2012-11-15 Thread laravot
Liron Aravot has posted comments on this change. Change subject: core: Fix error message for locked disks .. Patch Set 11: (1 inline comment) Commit Message Line 8: Line 9:

[Engine-patches] Change in ovirt-engine[engine_3.1]: packaging: Updated allinone plugin for new security mode

2012-11-15 Thread mgoldboi
Moran Goldboim has posted comments on this change. Change subject: packaging: Updated allinone plugin for new security mode .. Patch Set 1: Juan, have you verified it on top of 3.1 branch? -- To view, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: core: Fix error message for locked disks

2012-11-15 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core: Fix error message for locked disks .. Patch Set 11: Should the message be changed from "The following disks are locked:" to "The following disk(s) are loc

[Engine-patches] Change in ovirt-dwh[master]: packaging: fixed setup issues (#876240\876242)

2012-11-15 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: packaging: fixed setup issues (#876240\876242) .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9277 To unsubscribe, v

[Engine-patches] Change in ovirt-dwh[master]: packaging: fixed setup issues (#876240\876242)

2012-11-15 Thread ydary
Yaniv Dary has submitted this change and it was merged. Change subject: packaging: fixed setup issues (#876240\876242) .. packaging: fixed setup issues (#876240\876242) - made etl run always with the ovirt engine java version.

[Engine-patches] Change in ovirt-dwh[master]: packaging: fixed setup issues (#876240\876242)

2012-11-15 Thread ydary
Yaniv Dary has uploaded a new change for review. Change subject: packaging: fixed setup issues (#876240\876242) .. packaging: fixed setup issues (#876240\876242) - made etl run always with the ovirt engine java version. - fixed

[Engine-patches] Change in ovirt-engine[master]: core: Extract disk alias generation methods

2012-11-15 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Extract disk alias generation methods .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/9273 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: tools: engine-config need to remove all ver 2.2 values

2012-11-15 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: tools: engine-config need to remove all ver 2.2 values .. Patch Set 5: (1 inline comment) File backend/man

[Engine-patches] Change in ovirt-engine[master]: core: Extract disk alias generation methods

2012-11-15 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Extract disk alias generation methods .. core: Extract disk alias generation methods Extracted the methods used to generate disk alias from ImagesHandler

[Engine-patches] Change in ovirt-engine[master]: restapi: API should expose hypervisor version (#829625)

2012-11-15 Thread bazulay
Barak Azulay has posted comments on this change. Change subject: restapi: API should expose hypervisor version (#829625) .. Patch Set 3: (1 inline comment) File backend/mana

[Engine-patches] Change in ovirt-engine[master]: core: libosinfo - introduce libosinfo service

2012-11-15 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: libosinfo - introduce libosinfo service .. Patch Set 8: I would prefer that you didn't submit this (10 inline comments) -1 given since the tests won't pa

[Engine-patches] Change in ovirt-engine[master]: tools: engine-config need to remove all ver 2.2 values

2012-11-15 Thread rnori
Ravi Nori has posted comments on this change. Change subject: tools: engine-config need to remove all ver 2.2 values .. Patch Set 5: (1 inline comment) File backend/manager/

[Engine-patches] Change in ovirt-engine[master]: core: Update the commons-lang 2.6

2012-11-15 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Update the commons-lang 2.6 .. Patch Set 1: Verified Not much to verify, just that the build and the tests works, as we are already using version 2.6 in

[Engine-patches] Change in ovirt-engine[master]: core: Update the commons-lang 2.6

2012-11-15 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Update the commons-lang 2.6 .. core: Update the commons-lang 2.6 This is the version that we are using in deployments as it is included in Fedora, just n

[Engine-patches] Change in ovirt-engine[master]: webadmin: UI Plugins PoC, revision 7

2012-11-15 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: webadmin: UI Plugins PoC, revision 7 .. Patch Set 2: (2 inline comments) File frontend/webadmin/modules/fr

[Engine-patches] Change in ovirt-engine[master]: core: Fix error message for locked disks

2012-11-15 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: core: Fix error message for locked disks .. Patch Set 11: Verified -- To view, visit http://gerrit.ovirt.org/8693 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: Introducing update of vdsm task ID at Db

2012-11-15 Thread yzaslavs
Yair Zaslavsky has abandoned this change. Change subject: core: Introducing update of vdsm task ID at Db .. Patch Set 1: Abandoned Not needed - will be handled by next patches - -- To view, visit http://gerrit.ovirt.org/9257 T

[Engine-patches] Change in ovirt-engine[master]: engine: Clean up of exceptions

2012-11-15 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Clean up of exceptions .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/9267 To unsubscribe, visit http://gerrit.ovirt.org/settings G

[Engine-patches] Change in ovirt-engine[master]: engine: Removed duplicate retrieve of vdsm task, during SPM ...

2012-11-15 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Removed duplicate retrieve of vdsm task, during SPM election .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/9266 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: engine: Removed duplicate retrieve of vdsm task, during SPM ...

2012-11-15 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: engine: Removed duplicate retrieve of vdsm task, during SPM election .. engine: Removed duplicate retrieve of vdsm task, during SPM election The following fix

[Engine-patches] Change in ovirt-engine[master]: engine: Clean up of exceptions

2012-11-15 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: engine: Clean up of exceptions .. engine: Clean up of exceptions The following patch is removing unneeded exceptions, unneeded catch of exceptions, unneeded c

[Engine-patches] Change in ovirt-engine[master]: core: Quota refactor

2012-11-15 Thread omasad
ofri masad has posted comments on this change. Change subject: core: Quota refactor .. Patch Set 7: (7 inline comments) File backend/manager/modules/bll/src/main/java/org/ov

[Engine-patches] Change in ovirt-engine[master]: webadmin: NPE fix when adding a domain (#856583)

2012-11-15 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: webadmin: NPE fix when adding a domain (#856583) .. Patch Set 3: Verified Just removed a dependency that shouldn't have been here. -- To view, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: webadmin: NPE fix when adding a domain (#856583)

2012-11-15 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: webadmin: NPE fix when adding a domain (#856583) .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/9259 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network main tab is not visible in some tree selec...

2012-11-15 Thread msalem
Muli Salem has submitted this change and it was merged. Change subject: webadmin: Network main tab is not visible in some tree selections. .. webadmin: Network main tab is not visible in some tree selections. Network Main Tab

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network main tab is not visible in some tree selec...

2012-11-15 Thread msalem
Muli Salem has posted comments on this change. Change subject: webadmin: Network main tab is not visible in some tree selections. .. Patch Set 12: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network main tab is not visible in some tree selec...

2012-11-15 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Network main tab is not visible in some tree selections. .. Patch Set 12: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9077 To u

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network main tab is not visible in some tree selec...

2012-11-15 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: Network main tab is not visible in some tree selections. .. Patch Set 12: Looks good to me, but someone else must approve -- To view, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: engine: Add Network Search for Host Name

2012-11-15 Thread msalem
Muli Salem has submitted this change and it was merged. Change subject: engine: Add Network Search for Host Name .. engine: Add Network Search for Host Name This patch adds the network_vds_view, to be used by the tree search fo

[Engine-patches] Change in ovirt-engine[master]: engine: Add Network Search for Host Name

2012-11-15 Thread msalem
Muli Salem has posted comments on this change. Change subject: engine: Add Network Search for Host Name .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9265 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: engine: Add Vds Port Validation 65535 (#871328)

2012-11-15 Thread msalem
Muli Salem has submitted this change and it was merged. Change subject: engine: Add Vds Port Validation 65535 (#871328) .. engine: Add Vds Port Validation 65535 (#871328) This patch changes the maximum port number to 65535 usin

[Engine-patches] Change in ovirt-engine[master]: engine: Add Vds Port Validation 65535 (#871328)

2012-11-15 Thread msalem
Muli Salem has posted comments on this change. Change subject: engine: Add Vds Port Validation 65535 (#871328) .. Patch Set 6: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9149 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: engine: Add Network Search for Host Name

2012-11-15 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Add Network Search for Host Name .. Patch Set 3: Looks good to me, approved (1 inline comment) File b

[Engine-patches] Change in ovirt-engine[master]: engine: Add Network Search for Cluster Name

2012-11-15 Thread msalem
Muli Salem has submitted this change and it was merged. Change subject: engine: Add Network Search for Cluster Name .. engine: Add Network Search for Cluster Name This patch adds the cluster name column to network_cluster_view.

[Engine-patches] Change in ovirt-engine[master]: engine: Add Network Search for Cluster Name

2012-11-15 Thread msalem
Muli Salem has posted comments on this change. Change subject: engine: Add Network Search for Cluster Name .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9155 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: Fix error message for locked disks

2012-11-15 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: core: Fix error message for locked disks .. Patch Set 10: Patch set 10 was submitted by mistake, Please ignore. -- To view, visit http://gerrit.ovirt.org/8693

[Engine-patches] Change in ovirt-engine[master]: engine: Add Network Search for Host Name

2012-11-15 Thread msalem
Muli Salem has posted comments on this change. Change subject: engine: Add Network Search for Host Name .. Patch Set 1: (2 inline comments) File backend/manager/modules/sear

[Engine-patches] Change in ovirt-engine[master]: tools: engine-config need to remove all ver 2.2 values

2012-11-15 Thread emesika
Eli Mesika has posted comments on this change. Change subject: tools: engine-config need to remove all ver 2.2 values .. Patch Set 5: (2 inline comments) File backend/manager

[Engine-patches] Change in ovirt-engine[master]: tools: engine-config need to remove all ver 2.2 values

2012-11-15 Thread rnori
Ravi Nori has posted comments on this change. Change subject: tools: engine-config need to remove all ver 2.2 values .. Patch Set 5: (1 inline comment) File backend/manager/d

[Engine-patches] Change in ovirt-engine[master]: core: libosinfo - Use libosinfoService to validate memory va...

2012-11-15 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: libosinfo - Use libosinfoService to validate memory values .. Patch Set 8: (1 inline comment) Commit Messa

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms - Build # 2187 - Fixed!

2012-11-15 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/2187/ Build Number: 2187 Build Status: Fixed Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network main tab is not visible in some tree selec...

2012-11-15 Thread masayag
Moti Asayag has posted comments on this change. Change subject: webadmin: Network main tab is not visible in some tree selections. .. Patch Set 10: Looks good to me, but someone else must approve -- To view, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: engine: Add Network Search for Host Name

2012-11-15 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Add Network Search for Host Name .. Patch Set 1: (2 inline comments) File backend/manager/modules/sea

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network main tab is not visible in some tree selec...

2012-11-15 Thread msalem
Muli Salem has posted comments on this change. Change subject: webadmin: Network main tab is not visible in some tree selections. .. Patch Set 9: (1 inline comment) File fr

[Engine-patches] Change in ovirt-engine[master]: bootstrap: detach OVirtUpgrader from VdsInstaller into OVirt...

2012-11-15 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into OVirtNodeUpgrade .. Patch Set 3: (1 inline comment)

[Engine-patches] Change in ovirt-engine[master]: engine: Add Network Search for Cluster Name

2012-11-15 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Add Network Search for Cluster Name .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9155 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network main tab is not visible in some tree selec...

2012-11-15 Thread masayag
Moti Asayag has posted comments on this change. Change subject: webadmin: Network main tab is not visible in some tree selection. .. Patch Set 9: (2 inline comments) Commit

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Distingushing between entity and vdsm task ids

2012-11-15 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: [WIP] core: Distingushing between entity and vdsm task ids .. Patch Set 4: (3 inline comments) File backend/

[Engine-patches] Change in ovirt-engine[master]: engine: Add Network Search for Host Name

2012-11-15 Thread msalem
Muli Salem has uploaded a new change for review. Change subject: engine: Add Network Search for Host Name .. engine: Add Network Search for Host Name This patch adds the network_vds_view, to be used by the tree search for Networ

[Engine-patches] Change in ovirt-engine[master]: engine: Gluster Volume Georeplication Stop

2012-11-15 Thread sesubram
Selvasundaram has posted comments on this change. Change subject: engine: Gluster Volume Georeplication Stop .. Patch Set 4: (1 inline comment) AuditLog messages added File

  1   2   >