Eli Mesika has posted comments on this change. Change subject: tools: engine-config need to remove all ver 2.2 values ......................................................................
Patch Set 5: (2 inline comments) .................................................... File backend/manager/dbscripts/common_sp.sql Line 99: END; $procedure$ Line 100: LANGUAGE plpgsql; Line 101: Line 102: -- Deletes keys from action_version_map for the given versions (if exists) Line 103: create or replace FUNCTION fn_db_delete_version_map(v_cluster_version varchar(10), v_sp_version varchar(40)) Agree also Line 104: returns void Line 105: AS $procedure$ Line 106: begin Line 107: if (exists (select 1 from action_version_map where cluster_minimal_version = v_cluster_version and storage_pool_minimal_version = v_sp_version)) then Line 105: AS $procedure$ Line 106: begin Line 107: if (exists (select 1 from action_version_map where cluster_minimal_version = v_cluster_version and storage_pool_minimal_version = v_sp_version)) then Line 108: begin Line 109: delete from action_version_map where cluster_minimal_version = v_cluster_version and storage_pool_minimal_version = v_sp_version; The if block is redundant , just do a delete if the condition is not matched , nothing happens Line 110: end; Line 111: end if; Line 112: END; $procedure$ Line 113: LANGUAGE plpgsql; -- To view, visit http://gerrit.ovirt.org/9131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08cccaa4724ae84785fa0f3d5ea4141626c0f575 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
