Yair Zaslavsky has posted comments on this change. Change subject: utils: ssh: move to member '_' convention ......................................................................
Patch Set 4: Looks good to me, but someone else must approve +1 on code issue + we need to push this series of patches (push = advanced with review, not git push :) that will be after +2 :) ) I still disagree on convention + there are all kinds of frameworks + IDEs (yes, people coding at Java like IDEs) relying on the convention you want to change. I think that its wrong to break the java bean convention - http://en.wikipedia.org/wiki/JavaBeans -- To view, visit http://gerrit.ovirt.org/9171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bca20cec1e309105805d2c741c56abf04ab33d5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
