Moti Asayag has posted comments on this change.

Change subject: engine: Add Network Search for Host Name
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File 
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkHostConditionFieldAutoCompleter.java
Line 1: package org.ovirt.engine.core.searchbackend;
Line 2: 
Line 3: public class NetworkHostConditionFieldAutoCompleter extends 
BaseConditionFieldAutoCompleter {
Line 4:     private static final String HOST_NAME = "NAME";
Due to current infra limitation of the search engine, the "NAME" field will not 
be clear enough under "Host_network" query.

Please modify it to HOST_NAME.
Line 5: 
Line 6:     public NetworkHostConditionFieldAutoCompleter() {
Line 7:         // Building the basic verbs dict.
Line 8:         mVerbs.put(HOST_NAME, HOST_NAME);


....................................................
File 
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java
Line 277:                             new 
NetworkHostConditionFieldAutoCompleter(),
Line 278:                             "network_vds_view",
Line 279:                             "network_vds_view",
Line 280:                             "vds_name",
Line 281:                             "vds_name ASC"));
please sort by network_name
Line 282:                 }
Line 283:             });
Line 284: 
Line 285:     static EntitySearchInfo getEntitySearchInfo(String key) {


--
To view, visit http://gerrit.ovirt.org/9265
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4567828abdba27f50f40e75a7989da965f475417
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to