Roy Golan has posted comments on this change. Change subject: core: libosinfo - Use libosinfoService to validate memory values ......................................................................
Patch Set 8: (1 inline comment) .................................................... Commit Message Line 14: 2. upgrade VmOsType enum ids to new IDs as represented by libosinfo - Line 15: mostly because prior to intrpducing cpuArch, VmOsType enum members represented v86_64 systems Line 16: by name. Line 17: e.g old form - "RHEL6x84" Line 18: new form - "rhel6" and cpuArch "x86_64" b/w compat for restapi wiill be made in the enum mapper similar to what I did in OvfReader Search is based on the enum members name thus the search language has completion covered with no cost. Line 19: 3. refactor VmHandler methods to use libosinfo Line 20: 4. remove old obsoleted config values which represented min memory Line 21: values. Line 22: -- To view, visit http://gerrit.ovirt.org/9049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d7d45ca14c11747081b7ce882fa22e0d1850a40 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
