Maor Lipchuk has posted comments on this change.
Change subject: [WIP] core: Distingushing between entity and vdsm task ids
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
Line 455: public SPMAsyncTask CreateTask(AsyncTaskType taskType,
AsyncTaskParameters taskParameters) {
Line 456: return AsyncTaskFactory.Construct(taskType, taskParameters);
Line 457: }
Line 458:
Line 459: public synchronized void UpdateTaskWithActionParameters(Guid
taskID, VdcActionParametersBase actionParameters) {
Probably, it's better to change the variable name taskId to vdsmTaskId here, to
sync the change with all methods.
Line 460: if (_tasks.containsKey(taskID)) {
Line 461: async_tasks currentDbAsyncTask =
_tasks.get(taskID).getParameters().getDbAsyncTask();
Line 462: currentDbAsyncTask.setaction_parameters(actionParameters);
Line 463: AsyncTaskUtils.updateAsyncTaskInDB(_tasks.get(taskID));
Line 463: AsyncTaskUtils.updateAsyncTaskInDB(_tasks.get(taskID));
Line 464: }
Line 465: }
Line 466:
Line 467: public synchronized void StartPollingTask(Guid taskID) {
same here
Line 468: if (_tasks.containsKey(taskID)) {
Line 469: _tasks.get(taskID).StartPollingTask();
Line 470: }
Line 471: }
Line 472:
Line 473: public synchronized ArrayList<AsyncTaskStatus>
PollTasks(java.util.ArrayList<Guid> taskIdList) {
Line 474: ArrayList<AsyncTaskStatus> returnValue = new
ArrayList<AsyncTaskStatus>();
Line 475:
Line 476: if (taskIdList != null && taskIdList.size() > 0) {
same here
Line 477: for (Guid taskId : taskIdList) {
Line 478: if (_tasks.containsKey(taskId)) {
Line 479: // task is still running or is still in the cache:
Line 480: _tasks.get(taskId).setLastStatusAccessTime();
--
To view, visit http://gerrit.ovirt.org/9230
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebfc85569ba1aa8bd840f7239f83b7f921a4bd8f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
