Ravi Nori has posted comments on this change. Change subject: tools: engine-config need to remove all ver 2.2 values ......................................................................
Patch Set 5: (1 inline comment) .................................................... File backend/manager/dbscripts/insert_data.sql Line 56: insert into event_notification_methods (method_id, method_type) values (0,'Email'); Line 57: Line 58: delete from action_version_map; Line 59: -- Inserting data to history timekeeping Line 60: Insert into dwh_history_timekeeping VALUES('lastSync',NULL,to_timestamp('01/01/2000', 'DD/MM/YYYY')); Hi Yair, in upgrade script upgrade/pre_upgrade/0000_config.sql I added. select fn_db_delete_version_map('2.2','2.2'); Which deletes all 2.2 keys and values, Do we need more cleanup? Line 61: RETURN; Line 62: END; $procedure$ Line 63: LANGUAGE plpgsql; Line 64: select insert_data(); -- To view, visit http://gerrit.ovirt.org/9131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08cccaa4724ae84785fa0f3d5ea4141626c0f575 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches