Ravi Nori has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
Line 141: if (!validateConnectedLuns(vds,
getParameters().getLunIds())) {
Line 142: return new Pair<Boolean, Map<String,
List<Guid>>>(Boolean.FALSE, resultMap);
Line 143: }
Line 144: }
Line 145: return new Pair<Boolean, Map<String,
List<Guid>>>(Boolean.TRUE, resultMap);
Hi Allon, the if statement is inside a for loop. I think it still has its
place. Please confirm
Line 146: }
Line 147:
Line 148: private boolean connectStorageToLunByVdsId(VDS vds, LUNs lun) {
Line 149: try {
--
To view, visit http://gerrit.ovirt.org/9131
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08cccaa4724ae84785fa0f3d5ea4141626c0f575
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
