Moti Asayag has posted comments on this change.
Change subject: webadmin: Network main tab is not visible in some tree
selection.
......................................................................
Patch Set 9: (2 inline comments)
....................................................
Commit Message
Line 3: AuthorDate: 2012-11-06 14:22:53 +0200
Line 4: Commit: Muli Salem <msa...@redhat.com>
Line 5: CommitDate: 2012-11-15 13:51:09 +0200
Line 6:
Line 7: webadmin: Network main tab is not visible in some tree selection.
s/selection/selections
Line 8:
Line 9: Network Main Tab should be visible also when selecting in the tree-
Line 10: - Data Center
Line 11: - Cluster
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
Line 1150: }
Line 1151: else if (networkList.IsSearchStringMatch(source))
Line 1152: {
Line 1153: prefix.argvalue =
Line 1154: StringFormat.format("Network:
host_network.name = %1$s", model.getTitle()); //$NON-NLS-1$
for the sake of consistency as appeared on the auto-completed search box -
please change host_network to Host_network.
I'd suggest also changing the name to match the cluster-network search:
"Network: Cluster_network.cluster_name = %1$s"
"Network: host_network.host_name = %1$s"
Line 1155: }
Line 1156: }
Line 1157: break;
Line 1158:
--
To view, visit http://gerrit.ovirt.org/9077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id88e55cc18d244730b415400a43622dfe39df8dc
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
