Ravi Nori has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
..
Patch Set 4: (1 inline comment)
File
backend/manager/
Yair Zaslavsky has posted comments on this change.
Change subject: utils: tar: support long file names within tar
..
Patch Set 2:
Awesome!
I think we should have utils.archivers.tar
And have Tar under it (and the correct term
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
..
Patch Set 4:
Livnat - took me time to get back to your last comment.
Ok, so I did not understand your
Ayal Baron has posted comments on this change.
Change subject: core: UpdateVmDisk - clear snapshot_id for shareable disk
..
Patch Set 2: (5 inline comments)
File
backend/man
Roy Golan has abandoned this change.
Change subject: core: WIP libosinfo add mapping for libosinfo shortids.
..
Patch Set 3: Abandoned
replaced by change-id I1d7d45ca14c11747081b7ce882fa22e0d1850a40
--
To view, visit http://ge
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: layout: fix layout in new storage domain - iscsi
username
..
webadmin: layout: fix layout in new storage domain - iscsi username
Change-Id: I88
Daniel Erez has posted comments on this change.
Change subject: webadmin: layout: fix layout in new storage domain - iscsi
username
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org
Daniel Erez has posted comments on this change.
Change subject: webadmin: layout: fix layout in new storage domain - iscsi
username
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9185
To u
Daniel Erez has posted comments on this change.
Change subject: webadmin: LoginPopupView - construct form as table
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9153
To unsubscribe, visit http://gerrit.ovir
Daniel Erez has posted comments on this change.
Change subject: userportal: rephrase user-portal login dialog title
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9143
To unsubscribe, visit http://gerrit.ovi
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: split the logic of ovirt-node upgrade out
..
Patch Set 2: (1 inline comment)
File
backend/manager
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh: move to member '_' convention
..
Patch Set 2: (1 inline comment)
I think that now that java people start to review patches they need to adjust
to oth
Yair Zaslavsky has posted comments on this change.
Change subject: core: Event log - a method to bypass flow
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9148
To unsubscribe, visit http:/
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh: optimize progress streams
..
Patch Set 2:
I don't care to move... just tell where.
I don't think it will actually be used by anything else.
--
To vi
Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: handle bootstrap messages using string member
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: split the logic of ovirt-node upgrade out
..
Patch Set 2: (1 inline comment)
File
backend/manag
Alon Bar-Lev has posted comments on this change.
Change subject: utils: tests: do not use default key alias
..
Patch Set 2:
ok, although this class is gone in next patches :)
--
To view, visit http://gerrit.ovirt.org/9167
To u
Alon Bar-Lev has posted comments on this change.
Change subject: utils: tests: tar: cleanup main() entry point
..
Patch Set 2:
"Someone" is me.
Me stupid java programmer, which likes to test things as stanalone.
standalone =
Yair Zaslavsky has posted comments on this change.
Change subject: utils: ssh: move to member '_' convention
..
Patch Set 2: (1 inline comment)
IMHO, its bad our code has several code conventions (and I worked with all
kinds o
Alon Bar-Lev has posted comments on this change.
Change subject: utils: tar: support long file names within tar
..
Patch Set 2:
I can move it to whatever namespace you think best...
--
To view, visit http://gerrit.ovirt.org/91
Alon Bar-Lev has posted comments on this change.
Change subject: pki: accept subject name for certificate
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll
Yair Zaslavsky has posted comments on this change.
Change subject: utils: ssh: optimize progress streams
..
Patch Set 2:
Once again, very (very very) late in review -
Why not have a nice "streams" package in utils and have this
Alon Bar-Lev has posted comments on this change.
Change subject: pki: cleanup the ca interface
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/utils/src/main
Yair Zaslavsky has posted comments on this change.
Change subject: utils: ssh: fixup activity detection
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9169
To unsubscribe, visit http://gerr
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: allow distinguish error from non error messages
..
Patch Set 2: (1 inline comment)
The legacy (existing code) used xml.
The new code does not use xml.
Yair Zaslavsky has posted comments on this change.
Change subject: utils: ssh: don't add ssh command to exception
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9168
To unsubscribe, visit h
Yair Zaslavsky has posted comments on this change.
Change subject: utils: tests: do not use default key alias
..
Patch Set 2:
I will be glad to have more explanation in the commit msg, if possible.
--
To view, visit http://ger
Yair Zaslavsky has posted comments on this change.
Change subject: utils: tests: tar: cleanup main() entry point
..
Patch Set 2:
+10 on Allon's comment -
I suspect this a leftover of someone who was in a hurry and did not write
Yair Zaslavsky has posted comments on this change.
Change subject: utils: tar: throw an exception if base does not exist
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9165
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: utils: tar: support long file names within tar
..
Patch Set 2: Looks good to me, approved
Oops, did not notice that on previous reviews, maybe the package name
Yair Zaslavsky has posted comments on this change.
Change subject: pki: accept subject name for certificate
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/b
Yair Zaslavsky has posted comments on this change.
Change subject: pki: cleanup the ca interface
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
...
Daniel Erez has posted comments on this change.
Change subject: core: UpdateVmDisk - clear snapshot_id for shareable disk
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9231
To unsubscribe, visit http://gerr
Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: allow distinguish error from non error messages
..
Patch Set 2: (1 inline comment)
Alon Bar-Lev, do you think we might be facing a scenario with lots
Daniel Erez has uploaded a new change for review.
Change subject: core: UpdateVmDisk - clear snapshot_id for shareable disk
..
core: UpdateVmDisk - clear snapshot_id for shareable disk
UpdateVmDiskCommand should nullify vm_snaps
Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: do not get unique id at canDoAction
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9159
To
Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: do not get unique id at canDoAction
..
Patch Set 2: (1 inline comment)
See comment about Predicate/Linq/Collections +
Looks good to me.
Yair Zaslavsky has posted comments on this change.
Change subject: registration: fix null pointer exception
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9158
To unsubscribe, visit http://
Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: do not check connectivity nor unique id when
VdsInstall=false
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9
Einav Cohen has posted comments on this change.
Change subject: webadmin: layout: fix layout in new storage domain - iscsi
username
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
- Derez - can you pl
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Force flag should be set from parameters
..
core:Force flag should be set from parameters
When import VM or VM Template, we should set the force fla
Maor Lipchuk has posted comments on this change.
Change subject: core:Force flag should be set from parameters
..
Patch Set 4: Verified; Looks good to me, approved
Acked by mpastern
--
To view, visit http://gerrit.ovirt.org/92
Maor Lipchuk has posted comments on this change.
Change subject: core:Force flag should be set from parameters
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/9224
To unsubscribe, visit http://gerrit.ovirt.or
Yair Zaslavsky has uploaded a new change for review.
Change subject: [WIP] core: Distingushing between entity and vdsm task ids
..
[WIP] core: Distingushing between entity and vdsm task ids
This patch is first in series of patch
Michael Pasternak has posted comments on this change.
Change subject: core:Force flag should be set from parameters
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9224
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core:Force flag should be set from parameters
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9224
To
Liron Aravot has uploaded a new change for review.
Change subject: core: WIP: NPEs and wrong persisted information when reusing
LUNs
..
core: WIP: NPEs and wrong persisted information when reusing LUNs
Generally, the following
Liron Aravot has abandoned this change.
Change subject: core: WIP: NPEs and wrong persisted information when reusing
LUNs
..
Patch Set 3: Abandoned
--
To view, visit http://gerrit.ovirt.org/9228
To unsubscribe, visit http://ge
Allon Mureinik has posted comments on this change.
Change subject: core:Force flag should be set from parameters
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9224
To
Liron Aravot has uploaded a new change for review.
Change subject: core: WIP: issues when reusing LUNs
..
core: WIP: issues when reusing LUNs
This patch fixes the following issues
1. When removing a domain that used lun storage
Juan Hernandez has posted comments on this change.
Change subject: packaging: change handling of sysctl.conf
..
Patch Set 7: (6 inline comments)
File packaging/fedora/setup/b
Michael Pasternak has posted comments on this change.
Change subject: core:Force flag should be set from parameters
..
Patch Set 1: (2 inline comments)
File
backend/manager/
Liron Aravot has abandoned this change.
Change subject: core: issues when reusing LUNs
..
Patch Set 3: Abandoned
--
To view, visit http://gerrit.ovirt.org/9227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Mess
Ravi Nori has posted comments on this change.
Change subject: restapi: if filter: header is set, use query instead of search
(#869334)
..
Patch Set 3:
We will be fixing Networks in version 3.2
--
To view, visit http://gerrit.
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Correct migration related events
..
engine: Correct migration related events
The misleading events:
"Migration of VM xp_desktop from Host knight
Omer Frenkel has posted comments on this change.
Change subject: engine: Correct migration related events
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/9199
To unsubscribe, visit http://gerrit.ovirt.org/set
Omer Frenkel has posted comments on this change.
Change subject: engine: Correct migration related events
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9199
To unsubscribe, visit http://ge
Liron Aravot has uploaded a new change for review.
Change subject: core: LUNs issues when removing disks/domains
..
core: LUNs issues when removing disks/domains
this patch fixes the following issues
1. When removing a domain th
Omer Frenkel has posted comments on this change.
Change subject: engine: Correct migration related events
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9199
To unsubscribe, visit http://ge
Omer Frenkel has posted comments on this change.
Change subject: engine: re-run mechanism improvements
..
Patch Set 2: (1 inline comment)
looks good, minor comment
File
bac
Daniel Erez has posted comments on this change.
Change subject: webadmin:
..
Patch Set 1: Looks good to me, approved
please add subject to the commit message...
(i.e. postfix to "webadmin:" prefix)
--
To view, visit http://ger
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin:
..
webadmin:
1. Edit management network dialog didn't show correct message on top of it.
2. New Network dialog (from Cluster->Logical Network) didn't s
Allon Mureinik has posted comments on this change.
Change subject: core: Fix error message for locked disks
..
Patch Set 9: (5 inline comments)
File
backend/manager/modules/
Allon Mureinik has posted comments on this change.
Change subject: core:Force flag should be set from parameters
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Looks ok to me (see minor issu
Maor Lipchuk has uploaded a new change for review.
Change subject: core:Force flag should be set from parameters
..
core:Force flag should be set from parameters
When import VM or VM Template, we should set the force flag in the
Ohad Basan has posted comments on this change.
Change subject: core: Adding support for postgres 9.2(#869221)
..
Patch Set 1:
I believe this patch is irrelevant anymore since we've dropped the extension.
correct?
--
To view, v
Roy Golan has uploaded a new change for review.
Change subject: core: WIP libosinfo - add libosinfo RPM dependency
..
core: WIP libosinfo - add libosinfo RPM dependency
Change-Id: I1df74d7367af0e86f4a42beb019c928e5668ac83
Signed
Roy Golan has uploaded a new change for review.
Change subject: libosinfo - rename upgrade script
..
libosinfo - rename upgrade script
Change-Id: I641a02b6c95faad9d32cb8857b65f8b3be1ea5b7
Signed-off-by: Roy Golan
---
R backend/
Roy Golan has uploaded a new change for review.
Change subject: libosinfo - fix size calc
..
libosinfo - fix size calc
Change-Id: I1b141becdb0f0df0dccd6bde3e7f083ef61ddf82
Signed-off-by: Roy Golan
---
M
backend/manager/modules
Ravi Nori has uploaded a new change for review.
Change subject: restapi: API should expose hypervisor version (#829625)
..
restapi: API should expose hypervisor version (#829625)
Restapi should include the hypervisor version in
Ohad Basan has posted comments on this change.
Change subject: packaging: change handling of sysctl.conf
..
Patch Set 4: (1 inline comment)
File packaging/fedora/setup/basede
Ohad Basan has posted comments on this change.
Change subject: packaging: change handling of sysctl.conf
..
Patch Set 4: (4 inline comments)
File packaging/fedora/setup/engin
Juan Hernandez has posted comments on this change.
Change subject: packaging: Fix double ownership of backups directory.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Ohad Basan has posted comments on this change.
Change subject: packaging: change handling of sysctl.conf
..
Patch Set 3: (3 inline comments)
Commit Message
Line 7: packaging:
Juan Hernandez has posted comments on this change.
Change subject: packaging: change handling of sysctl.conf
..
Patch Set 4: (6 inline comments)
File packaging/fedora/setup/b
Ohad Basan has posted comments on this change.
Change subject: packaging: Fix double ownership of backups directory.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9216
To unsubscribe, visit http://gerrit.ov
Ohad Basan has posted comments on this change.
Change subject: packaging: Fix double ownership of backups directory.
..
Patch Set 1: (2 inline comments)
Commit Message
Line 3
Shahar Havivi has posted comments on this change.
Change subject: webadmin: layout: fix layout in new storage domain - iscsi
username
..
Patch Set 3: Verified
verify with the remove of the padding-left 5px;
--
To view, visit
Shahar Havivi has posted comments on this change.
Change subject: webadmin: layout: fix layout in new storage domain - iscsi
username
..
Patch Set 2: (2 inline comments)
Fil
Moti Asayag has posted comments on this change.
Change subject: engine: Add Vds Port Validation 65535 (#871328)
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9149
To unsubscribe, visit htt
Muli Salem has posted comments on this change.
Change subject: engine: Add Vds Port Validation 65535 (#871328)
..
Patch Set 2: (1 inline comment)
File
backend/manager/module
Juan Hernandez has posted comments on this change.
Change subject: packaging: change refence to new sysctl.conf location
..
Patch Set 3: (1 inline comment)
Commit Message
Lin
Juan Hernandez has posted comments on this change.
Change subject: packaging: change refence to new sysctl.conf location
..
Patch Set 3: (2 inline comments)
I think this is the right thing to do, just some comments on the way t
Ohad Basan has abandoned this change.
Change subject: backend: changing template1 encoding to utf8
..
Patch Set 7: Abandoned
Alternative patch sent instead
http://gerrit.ovirt.org/#/c/8955/
--
To view, visit http://gerrit.ovir
Kanagaraj M has posted comments on this change.
Change subject: engine: Gluster Peer Detach bll command
..
Patch Set 1:
Please add GlusterHostRemoveCommand to VdcActionType.
--
To view, visit http://gerrit.ovirt.org/9044
To un
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: WIP libosinfo add mapping for libosinfo shortids.
..
Patch Set 3: I would prefer that you didn't submit this
(4 inline comments)
Mostly naggi
Liron Aravot has posted comments on this change.
Change subject: core: Fix error message for locked disks
..
Patch Set 9: (2 inline comments)
File
backend/manager/modules/bl
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: WIP - libosinfo UI - create a renderer for VmOsType labels
..
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
...
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: WIP - libosinfo delete unused queries
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: WIP introduce new libosinfo query
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Rather trivial comment inline
Juan Hernandez has posted comments on this change.
Change subject: Packaging: inrecursive ownership of backend package on backups
directory.
..
Patch Set 1: (2 inline comments)
The change looks good to me, I only have some sug
Ohad Basan has uploaded a new change for review.
Change subject: Packaging: inrecursive ownership of backend package on backups
directory.
..
Packaging: inrecursive ownership of backend package on backups directory.
Currently r
Ravi Nori has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
..
Patch Set 4:
I will clean up action_version_map table and RemoveVGVDSCommand
--
To view, visit http://gerr
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix error message for locked disks
..
Patch Set 9: (1 inline comment)
File
backend/manager/modules/bll
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix error message for locked disks
..
Patch Set 9: Looks good to me, but someone else must approve
(1 inline comment)
Like
...
Yair Zaslavsky has posted comments on this change.
Change subject: core: Quota refactor - parameters
..
Patch Set 15: (1 inline comment)
File
backend/manager/modules/bll/src
Eli Mesika has uploaded a new change for review.
Change subject: core:Fence Host fails if something ...(#871768)
..
core:Fence Host fails if something ...(#871768)
Fence Host fails if something went wrong in
FenceQuietTimeBetwe
Daniel Erez has posted comments on this change.
Change subject: webadmin: layout: fix layout in new storage domain - iscsi
username
..
Patch Set 2: (2 inline comments)
File
Daniel Erez has posted comments on this change.
Change subject: webadmin: reformat remove disk messages
..
Patch Set 3: I would prefer that you didn't submit this
breaks the build using -Pall-langs
(should probably fix CommonAp
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2729/
Build Number: 2729
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,446
-
Changes Since
1 - 100 of 129 matches
Mail list logo
