Liron Aravot has posted comments on this change.
Change subject: core: Fix error message for locked disks
......................................................................
Patch Set 9: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 507: }
Line 508: }
Line 509:
Line 510: if (lockedDisksAliases.size() > 0) {
Line 511: ListUtils.nullSafeAdd(messages,
VdcBllMessages.ACTION_TYPE_FAILED_DISKS_LOCKED.toString());
that should be nullSafeAdd as well - otherwise can cause to NPE
Line 512: messages.add(String.format("$%1$s %2$s", "diskAliases",
StringUtils.join(lockedDisksAliases, ", ")));
Line 513: }
Line 514:
Line 515: if (returnValue && vm.getstatus() == VMStatus.ImageLocked) {
....................................................
Commit Message
Line 8:
Line 9: This fix is related to bug Bug-Url: https://bugzilla.redhat.com/865551 ,
Line 10: though not specifically mentioned there.
Line 11: It fixes an error message displayed when trying to run a VM while one
or
Line 12: more of its disks are locked. Previous message showed multiple disks
That's the behaviour of the new message as well..please fix the commit message.
thanks
Line 13: locked message (even when there was only one), and disks_aliases was
not
Line 14: substituted with actual disks aliases. The same issue occured with
Line 15: MoveOrCopyDiskCommand. Now one message replaces the
Line 16: two previous ones, along with the correct disk(s) alias(es).
--
To view, visit http://gerrit.ovirt.org/8693
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c56d9d2926eaf34b4a279c8d61a8cb166524da9
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
