Yair Zaslavsky has posted comments on this change.

Change subject: pki: accept subject name for certificate
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java
Line 370:         case SignCertificateRequest: {
Line 371:             try {
Line 372:                 _certificate = 
OpenSslCAWrapper.SignCertificateRequest(
Line 373:                     _request,
Line 374:                     _vds.gethost_name(),
I just want to extra-verify (and maybe understand more) - is this ok that 
vds.gethost_name() is passed twice?
Line 375:                     _vds.gethost_name()
Line 376:                 );
Line 377: 
Line 378:                 _executionSucceded = true;


--
To view, visit http://gerrit.ovirt.org/9163
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9798deff39a69f9fd25c0ab9e998b5a7b206daeb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to