Yair Zaslavsky has posted comments on this change.
Change subject: core: Quota refactor - parameters
......................................................................
Patch Set 15: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 649: throw new InvalidQuotaParametersException("Command: " +
this.getClass().getName()
Line 650: + ". No Quota parameters available.");
Line 651: }
Line 652:
Line 653: boolean result =
true;//getQuotaManager().consume(quotaConsumptionParametersWrapper);
Hmm,
I think this is misleading :) I have a feeling this is the case, you should
have been more clear on this, and I'm sure someone else will ask that in 6
reviews from now:)
Line 654: setQuotaWasChanged(result);
Line 655: return result;
Line 656: }
Line 657:
--
To view, visit http://gerrit.ovirt.org/8775
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebfc85569ba1aa8bd840f7239f83b7f921a4bd8e
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
