Ravi Nori has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateStorageDomainVDSCommand.java
Line 9: }
Line 10:
Line 11: @Override
Line 12: protected void ExecuteVdsBrokerCommand() {
Line 13: status =
getBroker().createStorageDomain(getParameters().getStorageDomain().getstorage_type().getValue(),
Hi Omer, I already removed createStorageDomain (the one we are not using) from
IVdsServer and VdsServerWrapper. What other cleanup do you have in mind? Thanks
Line 14:
getParameters().getStorageDomain().getId().toString(),
Line 15:
getParameters().getStorageDomain().getstorage_name(),
Line 16: getParameters().getArgs(),
Line 17:
getParameters().getStorageDomain().getstorage_domain_type().getValue(),
--
To view, visit http://gerrit.ovirt.org/9131
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08cccaa4724ae84785fa0f3d5ea4141626c0f575
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
