Yair Zaslavsky has posted comments on this change. Change subject: bootstrap: allow distinguish error from non error messages ......................................................................
Patch Set 2: (1 inline comment) Alon Bar-Lev, do you think we might be facing a scenario with lots of host registrating? Do we want to put an extra effort on the XML parsing? What do you think? .................................................... Commit Message Line 6: Line 7: bootstrap: allow distinguish error from non error messages Line 8: Line 9: The old bootstrap xml like protocol will remain for a while until the Line 10: note upgrade script rewritten. Till then we need to know if there was an should it be s/note/node ? What is note in our context , if my sed suggestion is wrong? Line 11: error message to fail the command without relaying on constants within Line 12: messages as VdsInstaller had done so far. Line 13: Line 14: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875528 -- To view, visit http://gerrit.ovirt.org/9161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62de9fab0ae3c10d245ed6c2580bf8fcc09057d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
