Frank Kobzik has posted comments on this change.
Change subject: userportal:Spice Option:Pass Ctrl-Alt-Del to VM is grayed out
on windows client
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/8906
To unsubs
Frank Kobzik has posted comments on this change.
Change subject: engine: User Portal - auto-connect selected only works once per
browser session
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/8851
To unsubs
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Get Volume Advanced Details Query
..
Patch Set 20: (2 inline comments)
Incorporated review comments.
Allon Mureinik has posted comments on this change.
Change subject: core: Dead store to tempVar in
GetTagsByUserIdQuery.executeQueryCommand()
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit htt
Shireesh Anjal has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 20: (1 inline comment)
New patch-set to follow, incorporating Allon's comments.
Alon Bar-Lev has posted comments on this change.
Change subject: tools: Fix locale issue (BZ858918)
..
Patch Set 1:
Why not?
--
To view, visit http://gerrit.ovirt.org/8919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Keith Robertson has uploaded a new change for review.
Change subject: tools: Fix locale issue (BZ858918)
..
tools: Fix locale issue (BZ858918)
Removed md5sum check as it isn't really
necessary.
Change-Id: Iaa74a561bcc2e585e73d0
Daniel Erez has posted comments on this change.
Change subject: webadmin: Fit New Storage Domain dialog for French locale
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8785
To unsubscribe,
Daniel Erez has posted comments on this change.
Change subject: core: better log when LUN in problem state
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8880
To unsubs
Daniel Erez has posted comments on this change.
Change subject: webadmin: Layout - Fit Cluster Networking for JP Locale - V2
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Changes on AbstractVali
Daniel Erez has posted comments on this change.
Change subject: webadmin: Layout: fit Pools general sub-tab for JP locale
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8891
To unsubscribe,
Daniel Erez has posted comments on this change.
Change subject: webadmin: Layout: fit Manage-Events for JP Locale
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8902
To unsubscrib
Daniel Erez has posted comments on this change.
Change subject: webadmin: Layout - make template dialog overlap with JP locale
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8886
Daniel Erez has posted comments on this change.
Change subject: webadmin: Add checkbox to override NFS mount options
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8798
To unsubscribe, visi
Daniel Erez has posted comments on this change.
Change subject: core, restapi: Convert NFS version to enum
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8797
To unsubs
Daniel Erez has posted comments on this change.
Change subject: core, webadmin: Use NFS v3 as default
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8242
To unsubscrib
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated VDC utilities to accept alternative binary
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/8913
To unsubscribe, visit http://
Sharad Mishra has posted comments on this change.
Change subject: core: Dead store to tempVar in
GetTagsByUserIdQuery.executeQueryCommand()
..
Patch Set 2: Verified
+2 for patchset 1. No code changes in patchset 2.
--
To view
Allon Mureinik has posted comments on this change.
Change subject: core, restapi: Convert NFS version to enum
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8797
To uns
Allon Mureinik has posted comments on this change.
Change subject: webadmin: Add checkbox to override NFS mount options
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8
Allon Mureinik has posted comments on this change.
Change subject: core, webadmin: Use NFS v3 as default
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8242
To unsubsc
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated VDC utilities to accept alternative binary
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated VDC utilities to accept alternative binary
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8913
To unsubscribe, visit http://
Allon Mureinik has posted comments on this change.
Change subject: core: Dead store to tempVar in
GetTagsByUserIdQuery.executeQueryCommand()
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
s
Allon Mureinik has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 21:
patchset 21:
+1 on adressing my comments from previous patches.
I'm not giving +1 since I'm not sure
Allon Mureinik has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 20: (2 inline comments)
patchset 20: answered questions inline
.
Sharad Mishra has abandoned this change.
Change subject: core: Renamed POSIXFSStorageHelper.java to
PosixFsStorageHelper.java
..
Patch Set 1: Abandoned
classs cannot be renamed as it is a created using reflection based on
Sto
Allon Mureinik has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 21: (1 inline comment)
answered inline
File backend
Allon Mureinik has posted comments on this change.
Change subject: core: Alert for deprecated NFS mount options in vdsm.conf
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: Fix run VM with locked disk msg
..
Patch Set 5: I would prefer that you didn't submit this
(4 inline comments)
..
Allon Mureinik has posted comments on this change.
Change subject: core: Fix err msg - disk locked on MoveOrCopyDisk
..
Patch Set 6: Looks good to me, but someone else must approve
(1 inline comment)
Minor style issue, see in
Allon Mureinik has posted comments on this change.
Change subject: core: WIP: verify iscsi lun connection when adding lun disk
..
Patch Set 4: (2 inline comments)
File
backe
Allon Mureinik has posted comments on this change.
Change subject: core: better log when LUN in problem state
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8880
To uns
Allon Mureinik has posted comments on this change.
Change subject: webadmin: Add checkbox to override NFS mount options
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8
Allon Mureinik has posted comments on this change.
Change subject: core, webadmin: Use NFS v3 as default
..
Patch Set 11: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8242
To unsubsc
Allon Mureinik has posted comments on this change.
Change subject: core, restapi: Convert NFS version to enum
..
Patch Set 7: Looks good to me, but someone else must approve
(1 inline comment)
See minor inline comment regardin
Juan Hernandez has uploaded a new change for review.
Change subject: core: Use template0 instead of template1
..
core: Use template0 instead of template1
This change was already initiated in commit
9538658ab884fc1d2e5a78fdd63a3e
Allon Mureinik has posted comments on this change.
Change subject: core: Add scan domain query (revised)
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Look OK to me - just remove the redund
Oved Ourfali has submitted this change and it was merged.
Change subject: webadin: layout: fix english new/edit pool layout
..
webadin: layout: fix english new/edit pool layout
revert patch 8a0c9f4b0d8b753a80a9c38ff04680c78db83
Oved Ourfali has posted comments on this change.
Change subject: webadin: layout: fix english new/edit pool layout
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8915
To unsubscri
Oved Ourfali has posted comments on this change.
Change subject: webadin: layout: fix english new/edit pool layout
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8915
To unsubscri
Shahar Havivi has uploaded a new change for review.
Change subject: webadin: layout: fix english new/edit pool layout
..
webadin: layout: fix english new/edit pool layout
revert patch 8a0c9f4b0d8b753a80a9c38ff04680c78db83b0c
Ch
ofri masad has posted comments on this change.
Change subject: webadmin: Fix localization issue in edit quota
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8914
To unsubscribe, visit http://gerrit.ovirt.org
ofri masad has uploaded a new change for review.
Change subject: webadmin: Fix localization issue in edit quota
..
webadmin: Fix localization issue in edit quota
Edit Quota popup view had some hard coded strings
which are imposi
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Updated VDC utilities to accept alternative binary
..
packaging: Updated VDC utilities to accept alternative binary
* Added the optional parameter for
Liron Aravot has abandoned this change.
Change subject: core: WIP: prevent simultaneous reconstructs on the same pool
..
Patch Set 5: Abandoned
abandoned for the moment.
--
To view, visit http://gerrit.ovirt.org/8911
To unsubs
Liron Aravot has restored this change.
Change subject: core: WIP: prevent simultaneous reconstructs on the same pool
..
Patch Set 4: Restored
--
To view, visit http://gerrit.ovirt.org/8911
To unsubscribe, visit http://gerrit.ov
Liron Aravot has abandoned this change.
Change subject: core: WIP: prevent simultaneous reconstructs on the same pool
..
Patch Set 4: Abandoned
--
To view, visit http://gerrit.ovirt.org/8911
To unsubscribe, visit http://gerrit.
Tomas Jelinek has submitted this change and it was merged.
Change subject: restapi: RFE: add smartcard support
..
restapi: RFE: add smartcard support
Added boolean flag "smartcard_enabled" to
VM and template
Change-Id: Ibddf2c
Tomas Jelinek has posted comments on this change.
Change subject: restapi: RFE: add smartcard support
..
Patch Set 5: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/8512
To unsubscribe,
Project: http://jenkins.ovirt.org/job/ovirt-mom_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-mom_create_rpms/12/
Build Number: 12
Build Status: Still Failing
Triggered By: Started by user Eyal Edri
-
Changes Since Last Success:
--
Project: http://jenkins.ovirt.org/job/ovirt-mom_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-mom_create_rpms/11/
Build Number: 11
Build Status: Still Failing
Triggered By: Started by user Eyal Edri
-
Changes Since Last Success:
--
Project: http://jenkins.ovirt.org/job/ovirt-mom_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-mom_create_rpms/10/
Build Number: 10
Build Status: Still Failing
Triggered By: Started by user Eyal Edri
-
Changes Since Last Success:
--
Shahar Havivi has posted comments on this change.
Change subject: webadmin: Layout: Fix JP Locale date string format
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8912
To unsubscribe, visit http://gerrit.ov
Shahar Havivi has uploaded a new change for review.
Change subject: webadmin: Layout: Fix JP Locale date string format
..
webadmin: Layout: Fix JP Locale date string format
Change-Id: I2374ec9cd97747646c3a94ad926b73e12f0746bd
Bu
Liron Aravot has posted comments on this change.
Change subject: core: WIP: prevent simultaneous reconstructs on the same pool
..
Patch Set 14:
this patch is abandoned as a new solution was sent upstream which has too many
cha
Liron Aravot has uploaded a new change for review.
Change subject: core: WIP: prevent simultaneous reconstructs on the same pool
..
core: WIP: prevent simultaneous reconstructs on the same pool
ReconsturctMasterDomain command ca
Liron Aravot has abandoned this change.
Change subject: core: WIP: prevent simultaneous reconstructs on the same pool
..
Patch Set 14: Abandoned
--
To view, visit http://gerrit.ovirt.org/7982
To unsubscribe, visit http://gerrit
Liron Aravot has abandoned this change.
Change subject: core: WIP: prevent simultaneous reconstructs on the same pool
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/8910
To unsubscribe, visit http://gerrit.
Sharad Mishra has posted comments on this change.
Change subject: core: add toString method to VM and VDS
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7640
To unsubsc
Tomas Jelinek has submitted this change and it was merged.
Change subject: engine: Integrate smartcard support
..
engine: Integrate smartcard support
This patch integrates the smartcard support into the
frontend and engine.
Th
Tomas Jelinek has posted comments on this change.
Change subject: engine: Integrate smartcard support
..
Patch Set 12: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8484
To unsubscribe, visit ht
Tomas Jelinek has posted comments on this change.
Change subject: engine: Integrate smartcard support
..
Patch Set 11: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/8484
To unsubscribe,
Liron Aravot has uploaded a new change for review.
Change subject: core: WIP: prevent simultaneous reconstructs on the same pool
..
core: WIP: prevent simultaneous reconstructs on the same pool
ReconsturctMasterDomain command ca
Greg Padgett has posted comments on this change.
Change subject: webadmin: Add checkbox to override NFS mount options
..
Patch Set 7: Verified
Rebased, no other changes
--
To view, visit http://gerrit.ovirt.org/8798
To unsubsc
Greg Padgett has posted comments on this change.
Change subject: core, webadmin: Use NFS v3 as default
..
Patch Set 11: Verified
Rebased, no other changes
--
To view, visit http://gerrit.ovirt.org/8242
To unsubscribe, visit ht
Greg Padgett has posted comments on this change.
Change subject: core, restapi: Convert NFS version to enum
..
Patch Set 7: Verified
Ori, thanks, updated with your input.
--
To view, visit http://gerrit.ovirt.org/8797
To unsub
Project: http://jenkins.ovirt.org/job/ovirt-mom_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-mom_create_rpms/9/
Build Number: 9
Build Status: Still Failing
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Sharad Mishra has posted comments on this change.
Change subject: core: removing unused static class
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8877
To unsubscribe,
Sharad Mishra has posted comments on this change.
Change subject: core: backup.sh script should allow (#866963)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
To u
Sharad Mishra has posted comments on this change.
Change subject: core: add marks for key-value in sysprep handler log (#870100)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Frank Kobzik has uploaded a new change for review.
Change subject: userportal:Spice Option:Pass Ctrl-Alt-Del to VM is grayed out
on windows client
..
userportal:Spice Option:Pass Ctrl-Alt-Del to VM is grayed out on windows clien
Muli Salem has submitted this change and it was merged.
Change subject: engine: Type Safety GetVmTemplatesByNetworkIdQuery
..
engine: Type Safety GetVmTemplatesByNetworkIdQuery
This patch adds type safety for
GetVmTemplatesAndN
Muli Salem has posted comments on this change.
Change subject: engine: Type Safety GetVmTemplatesByNetworkIdQuery
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8903
To unsubscrib
ofri masad has posted comments on this change.
Change subject: core: Quota refactor - QuotaManager step 4
..
Patch Set 5: (1 inline comment)
File
backend/manager/modules/bll
Moti Asayag has posted comments on this change.
Change subject: engine: Type Safety GetVmTemplatesByNetworkIdQuery
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8903
To unsubscribe, visit
ofri masad has posted comments on this change.
Change subject: core: Quota refactor - QuotaManager step 2
..
Patch Set 5: (6 inline comments)
File
backend/manager/modules/bl
Oved Ourfali has posted comments on this change.
Change subject: webadmin: Layout: fit Manage-Events for JP Locale
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8902
T
Liron Aravot has posted comments on this change.
Change subject: core: WIP: verify iscsi lun connection when adding lun disk
..
Patch Set 4: (1 inline comment)
File
backend/
Shahar Havivi has posted comments on this change.
Change subject: webadmin: Layout: fit Manage-Events for JP Locale
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8902
To unsubscribe, visit http://gerrit.ovi
Muli Salem has uploaded a new change for review.
Change subject: engine: Type Safety GetVmTemplatesByNetworkIdQuery
..
engine: Type Safety GetVmTemplatesByNetworkIdQuery
This patch adds type safety for
GetVmTemplatesAndNetworkIn
Liron Aravot has posted comments on this change.
Change subject: core: WIP: verify iscsi lun connection when adding lun disk
..
Patch Set 4: (1 inline comment)
File
backend/
Shahar Havivi has uploaded a new change for review.
Change subject: webadmin: Layout: fit Manage-Events for JP Locale
..
webadmin: Layout: fit Manage-Events for JP Locale
Change-Id: I82d22a02149750a92fe1fa0c92d15153a9ff9526
Bug-
ofri masad has posted comments on this change.
Change subject: core: Quota refactor - QuotaManager step 1
..
Patch Set 5: (2 inline comments)
File
backend/manager/modules/bl
Yair Zaslavsky has posted comments on this change.
Change subject: core: Quota refactor - QuotaManager step 3
..
Patch Set 5:
Locking explained.
I wonder if synchronized isn't an overkill on the values of the map (perhaps to
i
Shireesh Anjal has posted comments on this change.
Change subject: engine: Get Volume Advanced Details Query
..
Patch Set 20: (2 inline comments)
File
backend/manager/module
Ricky Hopper has abandoned this change.
Change subject: core: Add scan domain query (revised)
..
Patch Set 1: Abandoned
Code has been merged into the last incarnation of the patch. Thanks for the
help, Allon!
--
To view, visi
Yaniv Dary has posted comments on this change.
Change subject: reports: fixed date display on br13 (#870720)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8895
To unsubscribe, visit http:/
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: fixed date display on br13 (#870720)
..
reports: fixed date display on br13 (#870720)
Had missing field in date display that caused error.
Changed
+ rm -rf /home/jenkins/workspace/ovirt-mom_create_rpms/rpms/
+ rm -rf /home/jenkins/workspace/ovirt-mom_create_rpms/tarball
++ git log -1 --pretty=format:%h
+ git_head=f9f2c5e
++ date --utc +%Y%m%d
+ GIT_RELEASE=20121029.gitf9f2c5e
++ egrep '^RPM_RELEASE_VERSION' Makefile
++ sed '
/workspace/ovirt-mom_create_rpms/rpms/
+ rm -rf /home/jenkins/workspace/ovirt-mom_create_rpms/tarball
++ git log -1 --pretty=format:%h
+ git_head=f9f2c5e
++ date --utc +%Y%m%d
+ GIT_RELEASE=20121029.gitf9f2c5e
++ egrep '^RPM_RELEASE_VERSION' Makefile
egrep: Makefile: No such file or direct
/jenkins/workspace/ovirt-mom_create_rpms/tarball
++ git log -1 --pretty=format:%h
+ git_head=f9f2c5e
++ date --utc +%Y%m%d
+ GIT_RELEASE=20121029.gitf9f2c5e
++ egrep '^RPM_RELEASE_VERSION' Makefile
egrep: Makefile: No such file or directory
++ sed 's/^.*=//'
+ CURRENT_RELEASE=
+
Liron Aravot has uploaded a new change for review.
Change subject: core: WIP: verify iscsi lun connection when adding lun disk
..
core: WIP: verify iscsi lun connection when adding lun disk
When adding a lun disk there's no vali
/home/jenkins/workspace/ovirt-mom_create_rpms/tarball
++ git log -1 --pretty=format:%h
+ git_head=f9f2c5e
++ date --utc +%Y%m%d
+ GIT_RELEASE=20121029.gitf9f2c5e
++ egrep '^RPM_RELEASE_VERSION' Makefile
egrep: Makefile: No such file or directory
++ sed 's/^.*=//'
+ CURRENT_RELEASE=
+
/home/jenkins/workspace/ovirt-mom_create_rpms/rpms/
+ rm -rf /home/jenkins/workspace/ovirt-mom_create_rpms/tarball
++ git log -1 --pretty=format:%h
+ git_head=f9f2c5e
++ date --utc +%Y%m%d
+ GIT_RELEASE=20121029.gitf9f2c5e
++ egrep '^RPM_RELEASE_VERSION' Makefile
++ sed 's/^.*=//'
ofri masad has posted comments on this change.
Change subject: core: Quota refactor - QuotaManager step 4
..
Patch Set 5: (1 inline comment)
File
backend/manager/modules/bll
ofri masad has posted comments on this change.
Change subject: core: Quota refactor - QuotaManager step 3
..
Patch Set 5:
The locking actually remained the same as in the previous version. but never
the less, the locks in this
/workspace/ovirt-mom_create_rpms/dist
++ git log -1 --pretty=format:%h
+ git_head=f9f2c5e
++ date --utc +%Y%m%d
+ GIT_RELEASE=20121029.gitf9f2c5e
++ egrep '^RPM_RELEASE_VERSION' Makefile
++ sed 's/^.*=//'
egrep: Makefile: No such file or directory
+ CURRENT_RELEASE=
+ RPM_RELEA
Shireesh Anjal has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 20: (10 inline comments)
Thanks Allon for catching some good ones! Responses to comments inline. I'm
sen
--pretty=format:%h
+ git_head=f9f2c5e
++ date --utc +%Y%m%d
+ GIT_RELEASE=20121029.gitf9f2c5e
++ egrep '^RPM_RELEASE_VERSION' Makefile
++ sed 's/^.*=//'
egrep: Makefile: No such file or directory
+ CURRENT_RELEASE=
+ RPM_RELEASE_VERSION=.20121029.gitf9f2c5e
+ mkdir -p /home/jen
1 - 100 of 177 matches
Mail list logo
