Frank Kobzik has uploaded a new change for review. Change subject: userportal:Spice Option:Pass Ctrl-Alt-Del to VM is grayed out on windows client ......................................................................
userportal:Spice Option:Pass Ctrl-Alt-Del to VM is grayed out on windows client Steps to Reproduce: 1. Go to the RHEVM user portal (Basic or Extended) from a windows client 2. Go to console options of a running VM Pass Ctrl-Alt-Del to virtual machine is checked and grayed out. Expected result is that this option should be unchecked and grayed out. Fixed by adding check for windows client in the SpiceInterfaceImpl. Change-Id: I80b4144e31bf7cafa854945189dacff5fdc3a5af Signed-off-by: Frantisek Kobzik <fkob...@redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=868395 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java 1 file changed, 10 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/06/8906/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java index 74376be..9f5160d 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java @@ -25,10 +25,10 @@ private Event usbAutoShareChangedEvent = new Event( SpiceConsoleModel.UsbAutoShareChangedEventDefinition); - private Event wanColorDepthChangedEvent = new Event( + private final Event wanColorDepthChangedEvent = new Event( SpiceConsoleModel.wanColorDepthChangedEventDefinition); - private Event wanDisableEffectsChangeEvent = new Event( + private final Event wanDisableEffectsChangeEvent = new Event( SpiceConsoleModel.wanDisableEffectsChangeEventDefinition); private Version currentVersion = new Version(4, 4); @@ -67,8 +67,12 @@ wanOptionsEnabled = false; wanColorDepth = WanColorDepth.depth16; - // send the ctrl + alt + delete by default - sendCtrlAltDelete = true; + // send the ctrl + alt + delete by default on non windows systems + if (cat.os.equalsIgnoreCase("Windows")) { //$NON-NLS-1$ + sendCtrlAltDelete = false; + } else { + sendCtrlAltDelete = true; + } noTaskMgrExecution = true; } @@ -145,6 +149,7 @@ return currentVersion; } + @Override public void setCurrentVersion(Version currentVersion) { this.currentVersion = currentVersion; } @@ -397,6 +402,7 @@ return spiceBaseURL; } + @Override public void setSpiceBaseURL(String spiceBaseURL) { this.spiceBaseURL = spiceBaseURL; } -- To view, visit http://gerrit.ovirt.org/8906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I80b4144e31bf7cafa854945189dacff5fdc3a5af Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
