Allon Mureinik has posted comments on this change. Change subject: core: Add scan domain query (revised) ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) Look OK to me - just remove the redundant section from the commit message. (although the extra info in (1) and (3) is quite useful - just rephrase it so it isn't a change list) .................................................... Commit Message Line 10: currently recognized by oVirt. This is done partially through Line 11: the vdsm command GetImagesList, which is also implemented within Line 12: oVirt under this patch. (Revisions made code more efficient) Line 13: Line 14: Comments since last change: When the patch is merged, only the latest reversion will exist - the revisions are a purely gerrit concept. The explanation here is great, but it does not belong in the commit message, but in the patch's comment (in gerrit). Line 15: Line 16: 1) The reason this returns a list of Guid rather than DiskImage is because Line 17: the DiskImages that are loaded are only those that oVirt currently recognizes. Line 18: To return DiskImages, the query would have to construct those images itself, -- To view, visit http://gerrit.ovirt.org/8219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icce8e2cd12b9609ce82dbb7d255c08bdbc6dcc41 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ricky Hopper <ricky.hop...@gmail.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Ricky Hopper <ricky.hop...@gmail.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
