Allon Mureinik has posted comments on this change.
Change subject: core: WIP: verify iscsi lun connection when adding lun disk
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddDiskParameters.java
Line 6: public class AddDiskParameters extends VmDiskOperatinParameterBase {
Line 7: private static final long serialVersionUID = -7832310521101821905L;
Line 8: private Guid vmSnapshotId = null;
Line 9: private Guid storageDomainId = Guid.Empty;
Line 10: boolean validateLunConnection;
where is this set from?
Line 11:
Line 12: public boolean getValidateLunConnection() {
Line 13: return validateLunConnection;
Line 14: }
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java
Line 31: @Override
Line 32: public Response add(Disk disk) {
Line 33: validateDiskForCreation(disk);
Line 34: AddDiskParameters params = new AddDiskParameters();
Line 35: params.setValidateLunConnection(true);
Why is this necessarily true?
why not leave it up to the user?
Line 36: params.setDiskInfo(getMapper(Disk.class,
org.ovirt.engine.core.common.businessentities.Disk.class).map(disk, null));
Line 37: if (disk.isSetStorageDomains() &&
disk.getStorageDomains().isSetStorageDomains() &&
disk.getStorageDomains().getStorageDomains().get(0).isSetId()) {
Line 38:
params.setStorageDomainId(Guid.createGuidFromString(disk.getStorageDomains().getStorageDomains().get(0).getId()));
Line 39: } else if (disk.isSetStorageDomains() &&
disk.getStorageDomains().getStorageDomains().get(0).isSetName()) {
--
To view, visit http://gerrit.ovirt.org/8900
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8aa07be1fd6d6021481c8c0291458aff403304ee
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
