Allon Mureinik has posted comments on this change.
Change subject: core: Fix err msg - disk locked on MoveOrCopyDisk
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(1 inline comment)
Minor style issue, see inline.
Also, please address Maor's review when rebasing.
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java
Line 166: mockGetVmsListForDisk();
Line 167: }
Line 168:
Line 169: private void mockGetAllForImage()
Line 170: {
Move the "{" up a line.
Line 171: Map<Boolean, VmTemplate> map = Collections.singletonMap(true,
new VmTemplate());
Line 172:
doReturn(map).when(vmTemplateDao).getAllForImage(any(Guid.class));
Line 173: }
Line 174:
--
To view, visit http://gerrit.ovirt.org/8694
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic91e8718181db7b55b59ca53ddc86e8f76ebd83c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
