Shireesh Anjal has posted comments on this change.
Change subject: engine: Get Volume Advanced Details Query
......................................................................
Patch Set 20: (2 inline comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDao.java
Line 23: public GlusterVolumeEntity getByName(Guid clusterId, String
volName);
Line 24:
Line 25: public List<GlusterVolumeEntity> getByClusterId(Guid clusterId);
Line 26:
Line 27: public List<GlusterVolumeEntity> getByVolumesOption(Guid clusterId,
I think getVolumesByOption() or getByOption() sounds more intuitive..
Line 28: GlusterStatus status,
Line 29: String optionKey,
Line 30: String optionValue);
Line 31:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GlusterVolumeStatusReturnForXmlRpc.java
Line 68: private static final String MEMORY_MAXALLOC = "maxAlloc";
Line 69: private static final String MEMORY_POOLMISSES = "poolMisses";
Line 70: private static final String MEMORY_MAXSTDALLOC = "maxStdAlloc";
Line 71:
Line 72: private StatusForXmlRpc mStatus;
Does the "m" in mStatus signify something? If not, I think just "status" and
corresponding getter/setter would be better.
Line 73: private GlusterVolumeAdvancedDetails volumeAdvancedDetails = new
GlusterVolumeAdvancedDetails();
Line 74:
Line 75: public GlusterVolumeStatusReturnForXmlRpc(Guid clusterId,
Map<String, Object> innerMap) {
Line 76: super(innerMap);
--
To view, visit http://gerrit.ovirt.org/7807
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6b590eaebeb1d06b7278300d5e12b2dab9eb093
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
