Shireesh Anjal has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
......................................................................
Patch Set 20: (1 inline comment)
New patch-set to follow, incorporating Allon's comments.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java
Line 72: private static final String ENTITY_OPTION = "option";
Line 73: private static GlusterManager instance = new GlusterManager();
Line 74: private static Log log = LogFactory.getLog(GlusterManager.class);
Line 75: private static final int GLUSTER_REFRESH_RATE_LIGHT =
Line 76: Config.<Integer>
GetValue(ConfigValues.GlusterRefreshRateLight);
Great points both! I'll introduce methods as suggested by you so that any
changes to config values are picked up in next run of the scheduler.
Line 77: private static final int GLUSTER_REFRESH_RATE_HEAVY =
Line 78: Config.<Integer>
GetValue(ConfigValues.GlusterRefreshRateHeavy);
Line 79:
Line 80: private GlusterManager() {
--
To view, visit http://gerrit.ovirt.org/7288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b61eb6e93105e46e2706eac1d94bc10717224c2
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
