ofri masad has posted comments on this change.

Change subject: core: Quota refactor - QuotaManager step 1
......................................................................


Patch Set 5: (2 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 580:                     + ". Storage pool is not available for quota 
calculation. ");
Line 581:         }
Line 582: 
Line 583:         if (!consumptionParameters.isEmpty()) {
Line 584:             return 
QuotaManager.getInstance().consume(quotaConsumptionParametersWrapper);
Done
Line 585:         } else {
Line 586:             return true;
Line 587:         }
Line 588:     }


....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManagerAuditLogger.java
Line 18:     public static QuotaManagerAuditLogger getInstance() {
Line 19:         return INSTANCE;
Line 20:     }
Line 21: 
Line 22:     protected synchronized void auditLogStorage(AuditLogableBase 
auditLogableBase, AuditLogType auditLogType, String quotaName,
Done.
Line 23:                                              double 
storageUsagePercentage,
Line 24:                                              double 
storageRequestedPercentage) {
Line 25:         auditLogableBase.AddCustomValue("QuotaName", quotaName);
Line 26:         auditLogableBase.AddCustomValue("CurrentStorage", 
percentageFormatter.format(storageUsagePercentage));


--
To view, visit http://gerrit.ovirt.org/8776
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb100467a55b26e4219d1a2562da86b81ffdc032
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to