Daniel Erez has posted comments on this change.

Change subject: webadmin: Layout - Fit Cluster Networking for JP Locale - V2
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

Changes on AbstractValidatedWidgetWithLabel.ui.xml should be reverted.

....................................................
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.ui.xml
Line 28:                }
Line 29:                
Line 30:                .contentWidget {
Line 31:                        float: right;
Line 32:                        width: 230px;
This widget is the parent of numerous widgets all over the UI, it shouldn't be 
changed just for localization sake.
Line 33:                        padding: 0 5px;
Line 34:                        line-height: 30px;
Line 35:                }
Line 36:        </ui:style>


--
To view, visit http://gerrit.ovirt.org/8887
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a5943dbbe6e38d213de6872ea9175fe77363b1c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to