Greg Padgett has uploaded a new change for review.
Change subject: engine: remove unused notification config options
..
engine: remove unused notification config options
https://bugzilla.redhat.com/784386
The notification confi
Livnat Peer has posted comments on this change.
Change subject: rest: Add Port Mirroring to VM interface
..
Patch Set 15: (2 inline comments)
File
backend/manager/modules/re
Doron Fediuck has posted comments on this change.
Change subject: core: Return 1 from StoreUtils on error
..
Patch Set 2: Looks good to me, approved
Please verify it, and merge.
--
To view, visit http://gerrit.ovirt.org/4848
T
Livnat Peer has posted comments on this change.
Change subject: engine: clean up network monitoring code
..
Patch Set 1: (4 inline comments)
File
backend/manager/modules/vds
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Update the brick status during add brick
..
Patch Set 2: Verified
Rebased with master.
Modifed JUnit test, pls review AddBricksToGlusterVolumeCommand
Omer Frenkel has posted comments on this change.
Change subject: engine: Add Gluster host
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules/common/src/main/jav
Omer Frenkel has posted comments on this change.
Change subject: core: Add latency fields to disk image (#804995)
..
Patch Set 1: (1 inline comment)
File
backend/manager/mod
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal: design improvements
..
userportal: design improvements
includes:
- the action buttons on the template side tab and VM side tab
where hidden, when
Selvasundaram has abandoned this change.
Change subject: engine: Missed can do action message added
..
Patch Set 1: Abandoned
Fix submitted on Patch http://gerrit.ovirt.org/4827
--
To view, visit http://gerrit.ovirt.org/4868
T
Roy Golan has submitted this change and it was merged.
Change subject: engine: Refactor LdapProviderType and LdapVendorNameEnum
..
engine: Refactor LdapProviderType and LdapVendorNameEnum
This patch is still a work in progress.
Roy Golan has posted comments on this change.
Change subject: engine: Refactor LdapProviderType and LdapVendorNameEnum
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4727
To unsub
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Used host name instead of vds name in gluster peer
detach
..
Patch Set 1: (1 inline comment)
Fil
Roy Golan has posted comments on this change.
Change subject: engine: Refactor LdapProviderType and LdapVendorNameEnum
..
Patch Set 2:
that's an automated message of gerrit trying to merge the change but it failed
since the HE
ShaoHe Feng has posted comments on this change.
Change subject: add a new tool for auto-generate python entities from schema
..
Patch Set 1: (1 inline comment)
File src/codeg
Ayal Baron has posted comments on this change.
Change subject: webadmin: Disallow adding of more then one host to local DC
..
Patch Set 1: (1 inline comment)
File
frontend/w
Daniel Erez has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
..
Patch Set 1: (2 inline comments)
File
backend/manager/modules/vdsbroker/src/
Sharad Mishra has posted comments on this change.
Change subject: engine: clean up network monitoring code
..
Patch Set 1: (4 inline comments)
File
backend/manager/modules/v
Ayal Baron has posted comments on this change.
Change subject: core: Added GetManagementInterfaceAddressByVdsId query
..
Patch Set 1: I would prefer that you didn't submit this
(5 inline comments)
.
Ayal Baron has posted comments on this change.
Change subject: webadmin: Set Spice & VNC console models to use different query
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.
Allon Mureinik has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
..
Patch Set 1: I would prefer that you didn't submit this
(5 inline comments)
See inline.
Also, I'd prefer to see unit tests fo
Allon Mureinik has posted comments on this change.
Change subject: core: Added GetManagementInterfaceAddressByVdsId query
..
Patch Set 1: (3 inline comments)
Some minor comments - see inline.
..
Allon Mureinik has posted comments on this change.
Change subject: core: [CpuPinning] db support for cpu_pinning
..
Patch Set 8: Looks good to me, but someone else must approve
(1 inline comment)
..
Allon Mureinik has posted comments on this change.
Change subject: core: [CpuPinning] cleanup VmStaticDAODbFacadeImpl
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/459
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Build and run with Fedora 17 jboss-as
..
Patch Set 7: (2 inline comments)
More notes before the +2 :)
..
Maor Lipchuk has posted comments on this change.
Change subject: core:Rephrase message when default quota removed
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/4873
To unsubscribe, visit http://gerrit.ovirt
Maor Lipchuk has posted comments on this change.
Change subject: core: Add latency fields to disk image (#804995)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4879
To unsubscribe, visit http://gerrit.ovirt
ShaoHe Feng has posted comments on this change.
Change subject: add a new tool for auto-generate python entities from schema
..
Patch Set 1:
if you add an attribute of class, you just write the attribute without indent.
the p
ShaoHe Feng has uploaded a new change for review.
Change subject: add a new tool for auto-generate python entities from schema
..
add a new tool for auto-generate python entities from schema
it is troublesome to generate python
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Add latency fields to disk image (#804995)
..
core: Add latency fields to disk image (#804995)
https://bugzilla.redhat.com/804995
Expose latency fields fr
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: RunMultipleAction - error handling added
..
webadmin: RunMultipleAction - error handling added
Error handling code of RunMultipleAction is modified to
d
Doron Fediuck has posted comments on this change.
Change subject: core: OvfVmWriterTest
..
Patch Set 1:
Laszlo, please fix the commit message.
--
To view, visit http://gerrit.ovirt.org/4817
To unsubscribe, visit http://gerrit.
Tal Nisan has uploaded a new change for review.
Change subject: webadmin: Disallow adding of more then one host to local DC
..
webadmin: Disallow adding of more then one host to local DC
Changed the option to add more than one h
Juan Hernandez has posted comments on this change.
Change subject: core: OvfVmWriterTest
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4817
To unsubscribe, visit http:
Shahar Havivi has posted comments on this change.
Change subject: ui: Add Port Mirroring mode to Vm Interface dialog
..
Patch Set 16: No score
--
To view, visit http://gerrit.ovirt.org/3786
To unsubscribe, visit http://gerrit.o
Shahar Havivi has posted comments on this change.
Change subject: ui: Add Port Mirroring mode to Vm Interface dialog
..
Patch Set 16: Verified
--
To view, visit http://gerrit.ovirt.org/3786
To unsubscribe, visit http://gerrit.o
Juan Hernandez has posted comments on this change.
Change subject: packaging: Build and run with Fedora 17 jboss-as
..
Patch Set 7:
Rebased and added changes to the engine-upgrade.py script to update the right
packages.
--
To
Selvasundaram has posted comments on this change.
Change subject: engine: Add Gluster host
..
Patch Set 2: (3 inline comments)
File
backend/manager/modules/bll/src/main/java
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: filtering tree by application mode
..
webadmin: filtering tree by application mode
using recursion.
Change-Id: I2d807c5ece41c0c2bbe2c7384d6f38045e0a1
Maor Lipchuk has uploaded a new change for review.
Change subject: core:Rephrase message when default quota removed
..
core:Rephrase message when default quota removed
https://bugzilla.redhat.com/818501
1. Change the message to
Sharad Mishra has posted comments on this change.
Change subject: engine: Refactor LdapProviderType and LdapVendorNameEnum
..
Patch Set 2:
Is the last comment from "Gerrit Code Review" an automatic message or did
someome find
Juan Hernandez has posted comments on this change.
Change subject: packaging: Remove components.war
..
Patch Set 2: Verified
Verified host installation.
--
To view, visit http://gerrit.ovirt.org/4555
To unsubscribe, visit http
Omer Frenkel has posted comments on this change.
Change subject: engine: Add Gluster host
..
Patch Set 2: (3 inline comments)
File
backend/manager/modules/bll/src/main/java/
Moti Asayag has posted comments on this change.
Change subject: core: Add validation to MAC format (#756437)
..
Patch Set 4: (4 inline comments)
Added Alona to provide her feedback on UI side.
.
Omer Frenkel has posted comments on this change.
Change subject: engine: Update the brick status during add brick
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4825
To unsubscribe, visit h
Omer Frenkel has posted comments on this change.
Change subject: engine: Used host name instead of vds name in gluster peer
detach
..
Patch Set 1: (1 inline comment)
File
b
Livnat Peer has uploaded a new change for review.
Change subject: engine: clean up network monitoring code
..
engine: clean up network monitoring code
This patch is for cleanning up legacy conversion (c# to java) code .
Change-
Omer Frenkel has submitted this change and it was merged.
Change subject: core: fix jobProperties for delete vm and template from export
(#818111)
..
core: fix jobProperties for delete vm and template from export (#818111)
htt
Omer Frenkel has posted comments on this change.
Change subject: core: fix jobProperties for delete vm and template from export
(#818111)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovi
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/944/
Build Number: 944
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 1,341
-
Changes Since La
Omer Frenkel has posted comments on this change.
Change subject: core: fix jobProperties for delete vm and template from export
(#818111)
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/4714
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: core: fix jobProperties for delete vm and template from export
(#818111)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4
Moti Asayag has posted comments on this change.
Change subject: engine: add support for network port mirroring
..
Patch Set 12:
There are conflict issues with master branch:
backend/manager/modules/common/src/main/java/org/ovi
Moti Asayag has posted comments on this change.
Change subject: core: Use ping verb to check connectivity with host
..
Patch Set 3: (2 inline comments)
File
backend/manager/
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Adding support for VDSM version 4.10 (#822158)
..
core: Adding support for VDSM version 4.10 (#822158)
https://bugzilla.redhat.com/822158
Until
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding support for VDSM version 4.10 (#822158)
..
Patch Set 3: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/4869
Moti Asayag has posted comments on this change.
Change subject: core: fix jobProperties for delete vm and template from export
(#818111)
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding support for VDSM version 4.10 (#822158)
..
Patch Set 2: Verified; Looks good to me, approved
Verified -
Before adding this - could not add vdsm wi
Douglas Schilling Landgraf has posted comments on this change.
Change subject: core: Adding support for VDSM version 4.10 (#822158)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Mike Kolesnik has posted comments on this change.
Change subject: core: Use ping verb to check connectivity with host
..
Patch Set 3: Looks good to me, approved
(2 inline comments)
.
Michael Kublin has posted comments on this change.
Change subject: core : Master reconstruct leads to inconsistent state (#800839)
..
Patch Set 1: (1 inline comment)
File
b
Michael Kublin has posted comments on this change.
Change subject: core:Clenup. Remove containerId references
..
Patch Set 1:
Patch is ok, but couple of question :
I don't see any connection of patch to changes at retrieve temp
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Fixed test failure in BackendGlusterBrickResourceTest
..
restapi: Fixed test failure in BackendGlusterBrickResourceTest
The name of the act
Michael Pasternak has posted comments on this change.
Change subject: restapi: Fixed test failure in BackendGlusterBrickResourceTest
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org
Selvasundaram has uploaded a new change for review.
Change subject: restapi: Fixed test failure in BackendGlusterBrickResourceTest
..
restapi: Fixed test failure in BackendGlusterBrickResourceTest
The name of the action paramete
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Build and run with Fedora 17 jboss-as
..
Patch Set 6: (1 inline comment)
1. Small note about %conifg
2. What about engine-upgrade?
.
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding support for VDSM version 4.10 (#822158)
..
Patch Set 1:
As explained you before (just writing it down) -
If you look at other values i.e - ENGINEEA
Omer Frenkel has posted comments on this change.
Change subject: core: Adding support for VDSM version 4.10 (#822158)
..
Patch Set 1: Looks good to me, approved
according to yzas, updates should be in the update section regardl
Omer Frenkel has posted comments on this change.
Change subject: core: Adding support for VDSM version 4.10 (#822158)
..
Patch Set 1: No score
i see now that this value already appears in this file, please check what
should be
Omer Frenkel has posted comments on this change.
Change subject: core: Adding support for VDSM version 4.10 (#822158)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4869
To unsubscribe, vis
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Adding support for VDSM version 4.10 (#822158)
..
core: Adding support for VDSM version 4.10 (#822158)
https://bugzilla.redhat.com/822158
Until we move
Yair Zaslavsky has posted comments on this change.
Change subject: packaging: Build and run with Fedora 17 jboss-as
..
Patch Set 6: Looks good to me, but someone else must approve
Giving +1 on pure JBoss/Java issues.
Please rev
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/943/
Build Number: 943
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,340
-
Changes Since
Yaniv Dary has posted comments on this change.
Change subject: packaging: Adding remoteDb support to dwh
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
...
Moti Asayag has posted comments on this change.
Change subject: core: Use ping verb to check connectivity with host
..
Patch Set 3:
Removed IVdsServer.ping() and VdsServerConnector.futureGetCapabilities() since
there are no di
Yair Zaslavsky has posted comments on this change.
Change subject: core: version fix
..
Patch Set 6:
Laszlo, you can have a local fix, no need to submit it over and over.
--
To view, visit http://gerrit.ovirt.org/4679
To unsub
Maor Lipchuk has posted comments on this change.
Change subject: core: Add query for getting storages by image id
..
Patch Set 2:
Changed as mkublin suggested + added more tests
--
To view, visit http://gerrit.ovirt.org/3479
T
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Gluster Brick resource implementation
..
restapi: Gluster Brick resource implementation
Implementation of BackendGlusterBrickResource
- ge
Michael Pasternak has submitted this change and it was merged.
Change subject: engine: New query to fetch brick by id
..
engine: New query to fetch brick by id
In the process, renamed GetGlusterVolumeByIdQueryParameters to gene
Michael Pasternak has posted comments on this change.
Change subject: restapi: Gluster Brick resource implementation
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4786
To unsubsc
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Cluster schema changes
..
restapi: Cluster schema changes
Introduced the flags "virt_service" and "gluster_service" in the "Cluster"
schem
Michael Pasternak has posted comments on this change.
Change subject: restapi: Cluster schema changes
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4824
To unsubscribe, visit htt
Michael Pasternak has posted comments on this change.
Change subject: engine: New query to fetch brick by id
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4783
To unsubscribe, vi
Selvasundaram has posted comments on this change.
Change subject: restapi: Cluster schema changes
..
Patch Set 4: Verified
Rebased
--
To view, visit http://gerrit.ovirt.org/4824
To unsubscribe, visit http://gerrit.ovirt.org/se
Selvasundaram has posted comments on this change.
Change subject: restapi: Gluster Brick resource implementation
..
Patch Set 4: Verified
Rebased
--
To view, visit http://gerrit.ovirt.org/4786
To unsubscribe, visit http://gerr
Selvasundaram has posted comments on this change.
Change subject: engine: New query to fetch brick by id
..
Patch Set 3: Verified
Rebased
--
To view, visit http://gerrit.ovirt.org/4783
To unsubscribe, visit http://gerrit.ovirt
Yaniv Dary has posted comments on this change.
Change subject: packaging: Adding remoteDb support to dwh
..
Patch Set 4: I would prefer that you didn't submit this
Please talk to Eli about the create view function and implement
Yair Zaslavsky has posted comments on this change.
Change subject: core: version fix
..
Patch Set 6: I would prefer that you didn't submit this
Currently VDSM will report 4.10.
This will be added to supportedVDSM versions.
We s
Alex Lourie has posted comments on this change.
Change subject: packaging: Adding remoteDb support to dwh
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4707
Ayal Baron has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
..
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
F
Livnat Peer has posted comments on this change.
Change subject: core: Fix hierarchy of Bond Parameters classes
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4863
To unsubscribe, visit http
Roy Golan has submitted this change and it was merged.
Change subject: rest: fix non working display tag in attach network to cluster
..
rest: fix non working display tag in attach network to cluster
the network mapper treated
Roy Golan has posted comments on this change.
Change subject: rest: fix non working display tag in attach network to cluster
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4861
To
Yair Zaslavsky has posted comments on this change.
Change subject: core : Master reconstruct leads to inconsistent state (#800839)
..
Patch Set 1: (1 inline comment)
File
b
Omer Frenkel has posted comments on this change.
Change subject: engine: fix for Rebalance Start event notification.
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4752
Omer Frenkel has posted comments on this change.
Change subject: engine: New query to fetch brick by id
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4783
To unsubscribe, visit http://gerr
Omer Frenkel has posted comments on this change.
Change subject: core : Removing of using internal drive mapping at all vm
scenarious
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4506
To
Omer Frenkel has posted comments on this change.
Change subject: core : Master reconstruct leads to inconsistent state (#800839)
..
Patch Set 1: (1 inline comment)
File
bac
Omer Frenkel has posted comments on this change.
Change subject: core : Last patch for removing internal_drive_mappings
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4847
To unsubscribe, v
Ori Liel has posted comments on this change.
Change subject: restapi: Restore Snapshot Race Condition
..
Patch Set 1:
Do not submit until pre-integration approves
--
To view, visit http://gerrit.ovirt.org/4866
To unsubscribe,
Ori Liel has uploaded a new change for review.
Change subject: restapi: Restore Snapshot Race Condition
..
restapi: Restore Snapshot Race Condition
Change-Id: Icb9d0cc5afb2735fd1228a74ec703073d3ef352c
Signed-off-by: Ori Liel
--
1 - 100 of 115 matches
Mail list logo
