Ayal Baron has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java
Line 46: if (!grayedOutLUNsEnabled) {
name is wrong (rest api has no notion of "grayed out luns")
Also, need a comment or annotation or something that says that this code should
be deprecated once dc level 3.0 is no longer supported
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUNs.java
Line 274: @Transient
I believe this is not what you meant to do, please verify
Line 286: @Transient
same as above
Line 287: private boolean attached;
s/attached/inUse/ ?
--
To view, visit http://gerrit.ovirt.org/4858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia716e72c6caa097b42d8864ab23144149d360df2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
