Omer Frenkel has posted comments on this change.
Change subject: core: Add latency fields to disk image (#804995)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
Line 33: private Double readLatencyFromDiskImageDynamic;
why do you name the fields like this? ("fromBla..") i think the comment above
is enough, no? i don't see a reason to describe db scheme in the code like
this..
also, where else this can come from? you dont have readLatencyFromImages and
readLatencyFromVmStatic...
what will we do if someday we would like to refactor these fields to other
table?
--
To view, visit http://gerrit.ovirt.org/4879
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32ea8b7ab04004bc0e8aa3d1b3e31253e0a61b77
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
