Ofer Schreiber has posted comments on this change.

Change subject: packaging: Build and run with Fedora 17 jboss-as
......................................................................


Patch Set 6: (1 inline comment)

1. Small note about %conifg
2. What about engine-upgrade?

....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 565: %config(noreplace) %attr(-, %{engine_user}, %{engine_group}) 
%{engine_etc}/engine-service-users.properties
IMO, Those .properties files should not be config

--
To view, visit http://gerrit.ovirt.org/4416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5cda15e5219d1b6c8e8306fc7b4f196e6afc66b1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to