Moti Asayag has posted comments on this change. Change subject: core: Add validation to MAC format (#756437) ......................................................................
Patch Set 4: (4 inline comments) Added Alona to provide her feedback on UI side. .................................................... File backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterfaceValidationTest.java Line 26: @RunWith(PowerMockRunner.class) Please consider other solution for the PowerMockRunner, as decided to eliminate the use of it. Line 81: return VALID_MAC_ADDRESS.replace(VALID_MAC_ADDRESS.charAt(random.nextInt(VALID_MAC_ADDRESS.length())), 'x'); I think that VALID_MAC_ADDRESS.length() should be replaced with a constant to emphasis it is predefined value and shouldn't be depended on any mac address length calculation. Line 85: return VALID_MAC_ADDRESS.substring(0, random.nextInt(VALID_MAC_ADDRESS.length())); same here. Line 95: super(); you can omit this call -- To view, visit http://gerrit.ovirt.org/4375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d25cc5c48fb2ab48c9137cd167a43459cf03931 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
