Livnat Peer has posted comments on this change.
Change subject: engine: clean up network monitoring code
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
Line 869: for (String key : nics.keySet()) {
key can not be null, a map entry won't be formed for a null key.
Line 927: Map<String,Object> vlan = (Map<String,Object>)
vlans.get(key);
I agree that there is a potential NPE but it was there before this change as
well.
I'll send a fix for that in the next patch set
Line 944: for (String key : bonds.keySet()) {
key can not be null
Line 988: Map<String, Object> network = (Map<String, Object>)
networks.get(key);
key can not be null
--
To view, visit http://gerrit.ovirt.org/4871
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfbbbfb9c7c6020ea520a735eea1e847c5ae77c2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
