Ayal Baron has posted comments on this change. Change subject: webadmin: Set Spice & VNC console models to use different query ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java Line 512: String address = this function is over 240 lines long, that is only about x10 the longest method you should probably write. In the least you can move the code under: if (StringHelper.isNullOrEmpty(getEntity().getdisplay_ip()) to a separate function (connectToSpice or something) -- To view, visit http://gerrit.ovirt.org/4855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie73fffcc684f4230e11eadb2e61f126e57d84ab4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
