Allon Mureinik has posted comments on this change. Change subject: core: Added GetManagementInterfaceAddressByVdsId query ......................................................................
Patch Set 1: (3 inline comments) Some minor comments - see inline. .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/InterfaceDAODbFacadeImpl.java Line 161: It should be made private too. .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/InterfaceDAO.java Line 89: */ The convention of the class seems to be ending methods with "forVds", without the "ByVdsId" part. .................................................... File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/InterfaceDAOTest.java Line 280: This can be made static. -- To view, visit http://gerrit.ovirt.org/4854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6d855734c6cdec937de6ec91d1c80a23333eec8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
