Allon Mureinik has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(5 inline comments)
See inline.
Also, I'd prefer to see unit tests for the new functionallity.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java
Line 32:
You can use StoragePoolDAO.getForVds(Guid) instead of getting the VDS and then
the storage pool.
Also, please call the DAOS using getDbFacade() and not via
DbFacade.getInstance() - this way, we'll be able to spy the DAO for testing.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java
Line 29: protected void ExecuteVdsBrokerCommand() {
Please use getStoragePoolDAO() instead of
DbFacade.getInstance().getStoragePoolDAO()
Line 140: }
Please add a constant for "partitioned"
Line 141: if (xlun.contains("partitioned")) {
getBoolean returns a system property as a boolean.
I believe you meant to use valueOf(String)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
Line 132:
What about generics?
--
To view, visit http://gerrit.ovirt.org/4858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia716e72c6caa097b42d8864ab23144149d360df2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
