Re: [PR] GroupBy Optimization: Trim on the Fly [pinot]

2024-09-23 Thread via GitHub
gortiz commented on PR #7219: URL: https://github.com/apache/pinot/pull/7219#issuecomment-2370284171 Interesting contribution. Do you think this mode could be enabled using a hint so it won't break backward compatibility? -- This is an automated message from the Apache Git Service. To res

Re: [PR] colocated-without-hints [pinot]

2024-09-23 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1772688368 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java: ## @@ -0,0 +1,283 @@ +/** + * Licensed to the Apache Software Fo

Re: [PR] colocated-without-hints [pinot]

2024-09-23 Thread via GitHub
vrajat commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1772619586 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java: ## @@ -0,0 +1,283 @@ +/** + * Licensed to the Apache Software Fo

Re: [PR] Part-3: Working E2E Quickstart for Time Series Engine [pinot]

2024-09-23 Thread via GitHub
ankitsultana commented on PR #14048: URL: https://github.com/apache/pinot/pull/14048#issuecomment-2370155574 Thanks folks for the quick review. Will be raising smaller PRs going forward for incremental improvements and bug fixes -- This is an automated message from the Apache Git Service.

Re: [PR] Part-3: Working E2E Quickstart for Time Series Engine [pinot]

2024-09-23 Thread via GitHub
ankitsultana commented on code in PR #14048: URL: https://github.com/apache/pinot/pull/14048#discussion_r1772585067 ## pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/TimeSeriesBlock.java: ## @@ -33,11 +34,12 @@ public class TimeSeriesBlock {

Re: [PR] Part-3: Working E2E Quickstart for Time Series Engine [pinot]

2024-09-23 Thread via GitHub
ankitsultana merged PR #14048: URL: https://github.com/apache/pinot/pull/14048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (4bfa6ee989 -> c395d09c1f)

2024-09-23 Thread ankitsultana
This is an automated email from the ASF dual-hosted git repository. ankitsultana pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 4bfa6ee989 Make Custom Config Optional (#14014) add c395d09c1f Part-3: Working E2E Quickstart for Time Serie

Re: [PR] Dynamic evaluation of GroupBy Initial Capacity [pinot]

2024-09-23 Thread via GitHub
praveenc7 commented on code in PR #14001: URL: https://github.com/apache/pinot/pull/14001#discussion_r1772579379 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DefaultGroupByExecutor.java: ## @@ -183,4 +194,26 @@ public GroupKeyGenerator getGroupKeyG

Re: [PR] Dynamic evaluation of GroupBy Initial Capacity [pinot]

2024-09-23 Thread via GitHub
praveenc7 commented on code in PR #14001: URL: https://github.com/apache/pinot/pull/14001#discussion_r1772579144 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DefaultGroupByExecutor.java: ## @@ -183,4 +194,26 @@ public GroupKeyGenerator getGroupKeyG

Re: [PR] Dynamic evaluation of GroupBy Initial Capacity [pinot]

2024-09-23 Thread via GitHub
praveenc7 commented on code in PR #14001: URL: https://github.com/apache/pinot/pull/14001#discussion_r1772578809 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DefaultGroupByExecutor.java: ## @@ -110,7 +117,11 @@ public DefaultGroupByExecutor(QueryCo

Re: [PR] Part-3: Working E2E Quickstart for Time Series Engine [pinot]

2024-09-23 Thread via GitHub
ankitsultana commented on code in PR #14048: URL: https://github.com/apache/pinot/pull/14048#discussion_r1772533406 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java: ## @@ -245,6 +323,14 @@ private DispatchClient getOrCreateDispa

Re: [PR] Part-3: Working E2E Quickstart for Time Series Engine [pinot]

2024-09-23 Thread via GitHub
ankitsultana commented on code in PR #14048: URL: https://github.com/apache/pinot/pull/14048#discussion_r1772531424 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/timeseries/TimeSeriesExecutionContext.java: ## @@ -0,0 +1,49 @@ +/** + * Licensed to the Apache

Re: [PR] Part-3: Working E2E Quickstart for Time Series Engine [pinot]

2024-09-23 Thread via GitHub
ankitsultana commented on code in PR #14048: URL: https://github.com/apache/pinot/pull/14048#discussion_r1772526805 ## pinot-plugins/pinot-timeseries-lang/pinot-timeseries-m3ql/src/main/java/org/apache/pinot/tsdb/m3ql/time/TimeBucketComputer.java: ## @@ -0,0 +1,79 @@ +/** + * Li

Re: [PR] Part-3: Working E2E Quickstart for Time Series Engine [pinot]

2024-09-23 Thread via GitHub
ankitsultana commented on code in PR #14048: URL: https://github.com/apache/pinot/pull/14048#discussion_r1772521850 ## pinot-plugins/pinot-timeseries-lang/pinot-timeseries-m3ql/src/main/java/org/apache/pinot/tsdb/m3ql/M3TimeSeriesPlanner.java: ## @@ -0,0 +1,158 @@ +/** + * Licen

Re: [PR] Part-3: Working E2E Quickstart for Time Series Engine [pinot]

2024-09-23 Thread via GitHub
ankitsultana commented on code in PR #14048: URL: https://github.com/apache/pinot/pull/14048#discussion_r1772519939 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/TimeSeriesRequestHandler.java: ## @@ -0,0 +1,172 @@ +/** + * Licensed to the Apache Software F

Re: [PR] Part-3: Working E2E Quickstart for Time Series Engine [pinot]

2024-09-23 Thread via GitHub
ankitsultana commented on code in PR #14048: URL: https://github.com/apache/pinot/pull/14048#discussion_r1772518597 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/TimeSeriesRequestHandler.java: ## @@ -0,0 +1,172 @@ +/** + * Licensed to the Apache Software F

Re: [PR] Part-3: Working E2E Quickstart for Time Series Engine [pinot]

2024-09-23 Thread via GitHub
ankitsultana commented on code in PR #14048: URL: https://github.com/apache/pinot/pull/14048#discussion_r1772517709 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -236,6 +238,48 @@ public void processSqlWithMultiStageQueryEngin

Re: [PR] Part-3: Working E2E Quickstart for Time Series Engine [pinot]

2024-09-23 Thread via GitHub
ankitsultana commented on code in PR #14048: URL: https://github.com/apache/pinot/pull/14048#discussion_r1772515491 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -236,6 +238,48 @@ public void processSqlWithMultiStageQueryEngin

Re: [PR] [Multi-stage] Clean up unnecessary checks in rules [pinot]

2024-09-23 Thread via GitHub
codecov-commenter commented on PR #14066: URL: https://github.com/apache/pinot/pull/14066#issuecomment-2369880012 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14066?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) 01/01: remove checks introduced in https://github.com/apache/pinot/issues/12945 that is backward in compatible (#14016)

2024-09-23 Thread jiaguo
This is an automated email from the ASF dual-hosted git repository. jiaguo pushed a commit to branch HF-1415 in repository https://gitbox.apache.org/repos/asf/pinot.git commit d0de7f5570b74cf0cb13eb6c9504b1bef37b4bb1 Author: Jia Guo AuthorDate: Wed Sep 18 13:10:17 2024 -0700 remove checks i

(pinot) branch HF-1415 created (now d0de7f5570)

2024-09-23 Thread jiaguo
This is an automated email from the ASF dual-hosted git repository. jiaguo pushed a change to branch HF-1415 in repository https://gitbox.apache.org/repos/asf/pinot.git at d0de7f5570 remove checks introduced in https://github.com/apache/pinot/issues/12945 that is backward in compatible (

[PR] [Multi-stage] Clean up unnecessary checks in rules [pinot]

2024-09-23 Thread via GitHub
Jackie-Jiang opened a new pull request, #14066: URL: https://github.com/apache/pinot/pull/14066 - Remove unnecessary checks in `matches()` - Use `copy()` instead of `create()` if we are modifying a `RelNode` to preserve the hints -- This is an automated message from the Apache Git Serv

Re: [PR] Adding gauge unit tests for AbstractMetrics [pinot]

2024-09-23 Thread via GitHub
codecov-commenter commented on PR #14064: URL: https://github.com/apache/pinot/pull/14064#issuecomment-2369720646 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14064?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[I] Reduce load time for Pinot UI Home Page [pinot]

2024-09-23 Thread via GitHub
deepthi912 opened a new issue, #14065: URL: https://github.com/apache/pinot/issues/14065 In the Pinot UI home page currently the following is the behaviour: Redundant calls Multiple /instances calls, 2 for each component type (total 4*2=8) although one call should provide information f

[PR] Adding gauge unit tests for AbstractMetrics [pinot]

2024-09-23 Thread via GitHub
shauryachats opened a new pull request, #14064: URL: https://github.com/apache/pinot/pull/14064 This PR adds various test scenarios for gauges (global, table, partition) to increase testing reliability and code coverage (line coverage increased from 44% to 93% for `AbstractMetrics`).

(pinot) branch master updated: Make Custom Config Optional (#14014)

2024-09-23 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 4bfa6ee989 Make Custom Config Optional (#14014) 4bf

Re: [PR] Make Custom Config Optional [pinot]

2024-09-23 Thread via GitHub
jackjlli merged PR #14014: URL: https://github.com/apache/pinot/pull/14014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Part-4: Working E2E Quickstart for Time Series Engine [pinot]

2024-09-23 Thread via GitHub
raghavyadav01 commented on PR #14048: URL: https://github.com/apache/pinot/pull/14048#issuecomment-2369148601 test https://github.com/apache/pinot/actions/runs/10973640885/job/30479986608?pr=14048 is failing though it does not look to be related. -- This is an automated message from the

Re: [PR] Part-4: Working E2E Quickstart for Time Series Engine [pinot]

2024-09-23 Thread via GitHub
raghavyadav01 commented on code in PR #14048: URL: https://github.com/apache/pinot/pull/14048#discussion_r1771867719 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -236,6 +238,48 @@ public void processSqlWithMultiStageQueryEngi

Re: [I] Bump commons-io:commons-io from 2.11.0 to 2.16.1 [pinot]

2024-09-23 Thread via GitHub
abhioncbr closed issue #14026: Bump commons-io:commons-io from 2.11.0 to 2.16.1 URL: https://github.com/apache/pinot/issues/14026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] CAST(col AS STRING) does not work in 1.2.0 anymore [pinot]

2024-09-23 Thread via GitHub
piby180 closed issue #14052: CAST(col AS STRING) does not work in 1.2.0 anymore URL: https://github.com/apache/pinot/issues/14052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] CAST(col AS STRING) does not work in 1.2.0 anymore [pinot]

2024-09-23 Thread via GitHub
piby180 commented on issue #14052: URL: https://github.com/apache/pinot/issues/14052#issuecomment-2368910683 @yashmayya Thanks for the link. We might have then confused with single stage query engine. I'll close the issue -- This is an automated message from the Apache Git Service. To res

Re: [PR] Make Custom Config Optional [pinot]

2024-09-23 Thread via GitHub
ashishjayamohan commented on PR #14014: URL: https://github.com/apache/pinot/pull/14014#issuecomment-2368911633 @Jackie-Jiang Yeah, I'm unsure of how that got in there. I don't think I modified anything in that directory to begin with, but I removed it. -- This is an automated message fro

Re: [PR] Disable shading when pinot-fastdev profile is enabled [pinot]

2024-09-23 Thread via GitHub
rfscholte commented on code in PR #13956: URL: https://github.com/apache/pinot/pull/13956#discussion_r1771816878 ## pinot-connectors/pinot-spark-2-connector/pom.xml: ## @@ -35,6 +35,45 @@ + + build-shaded-jar + Review Comment: I think you want to use

Re: [PR] Make Custom Config Optional [pinot]

2024-09-23 Thread via GitHub
Jackie-Jiang commented on code in PR #14014: URL: https://github.com/apache/pinot/pull/14014#discussion_r1771816298 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TableConfig.java: ## @@ -77,14 +77,13 @@ public class TableConfig extends BaseJsonConfig { private

Re: [PR] Improve database handling in multi-stage engine [pinot]

2024-09-23 Thread via GitHub
Jackie-Jiang merged PR #14040: URL: https://github.com/apache/pinot/pull/14040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Improve database handling in multi-stage engine (#14040)

2024-09-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new f618cf3cc4 Improve database handling in multi-sta

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.28.6 deleted (was fac19379a0)

2024-09-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.28.6 in repository https://gitbox.apache.org/repos/asf/pinot.git was fac19379a0 Bump software.amazon.awssdk:bom from 2.28.5 to 2.28.6 The revi

(pinot) branch master updated (9e4138868a -> a706581e38)

2024-09-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 9e4138868a Bump dnsjava:dnsjava from 3.6.1 to 3.6.2 (#14061) add a706581e38 Bump software.amazon.awssdk:bom from 2

Re: [PR] Bump software.amazon.awssdk:bom from 2.28.5 to 2.28.6 [pinot]

2024-09-23 Thread via GitHub
Jackie-Jiang merged PR #14062: URL: https://github.com/apache/pinot/pull/14062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/dnsjava-dnsjava-3.6.2 deleted (was a8cd4e0fc8)

2024-09-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/dnsjava-dnsjava-3.6.2 in repository https://gitbox.apache.org/repos/asf/pinot.git was a8cd4e0fc8 Bump dnsjava:dnsjava from 3.6.1 to 3.6.2 The revisions that were on this br

Re: [PR] Bump dnsjava:dnsjava from 3.6.1 to 3.6.2 [pinot]

2024-09-23 Thread via GitHub
Jackie-Jiang merged PR #14061: URL: https://github.com/apache/pinot/pull/14061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (be44a69100 -> 9e4138868a)

2024-09-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from be44a69100 Bump io.grpc:grpc-bom from 1.66.0 to 1.68.0 (#14060) add 9e4138868a Bump dnsjava:dnsjava from 3.6.1 to

(pinot) branch dependabot/maven/io.grpc-grpc-bom-1.68.0 deleted (was adee1380f5)

2024-09-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/io.grpc-grpc-bom-1.68.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was adee1380f5 Bump io.grpc:grpc-bom from 1.66.0 to 1.68.0 The revisions that were on th

(pinot) branch master updated: Bump io.grpc:grpc-bom from 1.66.0 to 1.68.0 (#14060)

2024-09-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new be44a69100 Bump io.grpc:grpc-bom from 1.66.0 to 1

Re: [PR] Bump io.grpc:grpc-bom from 1.66.0 to 1.68.0 [pinot]

2024-09-23 Thread via GitHub
Jackie-Jiang merged PR #14060: URL: https://github.com/apache/pinot/pull/14060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/org.apache.thrift-libthrift-0.21.0 deleted (was b82972d693)

2024-09-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.thrift-libthrift-0.21.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was b82972d693 Bump org.apache.thrift:libthrift from 0.18.1 to 0.21.0 Th

Re: [PR] Bump org.apache.thrift:libthrift from 0.18.1 to 0.21.0 [pinot]

2024-09-23 Thread via GitHub
Jackie-Jiang closed pull request #14059: Bump org.apache.thrift:libthrift from 0.18.1 to 0.21.0 URL: https://github.com/apache/pinot/pull/14059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Bump org.apache.thrift:libthrift from 0.18.1 to 0.21.0 [pinot]

2024-09-23 Thread via GitHub
dependabot[bot] commented on PR #14059: URL: https://github.com/apache/pinot/pull/14059#issuecomment-2368694270 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

(pinot) branch dependabot/maven/org.jline-jline-3.27.0 deleted (was 45fd5931b9)

2024-09-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.jline-jline-3.27.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 45fd5931b9 Bump org.jline:jline from 3.26.3 to 3.27.0 The revisions that were on this

(pinot) branch master updated (7faa9491aa -> 944c406618)

2024-09-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 7faa9491aa Bump com.github.luben:zstd-jni from 1.5.6-5 to 1.5.6-6 (#14057) add 944c406618 Bump org.jline:jline fr

Re: [PR] Bump org.jline:jline from 3.26.3 to 3.27.0 [pinot]

2024-09-23 Thread via GitHub
Jackie-Jiang merged PR #14058: URL: https://github.com/apache/pinot/pull/14058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/com.github.luben-zstd-jni-1.5.6-6 deleted (was b3523687d8)

2024-09-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.github.luben-zstd-jni-1.5.6-6 in repository https://gitbox.apache.org/repos/asf/pinot.git was b3523687d8 Bump com.github.luben:zstd-jni from 1.5.6-5 to 1.5.6-6 The rev

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-5 to 1.5.6-6 [pinot]

2024-09-23 Thread via GitHub
Jackie-Jiang merged PR #14057: URL: https://github.com/apache/pinot/pull/14057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Bump com.github.luben:zstd-jni from 1.5.6-5 to 1.5.6-6 (#14057)

2024-09-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 7faa9491aa Bump com.github.luben:zstd-jni from 1.

(pinot) branch dependabot/maven/com.yammer.metrics-metrics-core-2.2.0 deleted (was 1e54691a05)

2024-09-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.yammer.metrics-metrics-core-2.2.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 1e54691a05 Bump com.yammer.metrics:metrics-core from 2.1.5 to 2.2.

Re: [PR] Bump com.yammer.metrics:metrics-core from 2.1.5 to 2.2.0 [pinot]

2024-09-23 Thread via GitHub
dependabot[bot] commented on PR #14056: URL: https://github.com/apache/pinot/pull/14056#issuecomment-2368691003 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump com.yammer.metrics:metrics-core from 2.1.5 to 2.2.0 [pinot]

2024-09-23 Thread via GitHub
Jackie-Jiang closed pull request #14056: Bump com.yammer.metrics:metrics-core from 2.1.5 to 2.2.0 URL: https://github.com/apache/pinot/pull/14056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump io.github.hakky54:sslcontext-kickstart-for-netty from 8.3.6 to 8.3.7 [pinot]

2024-09-23 Thread via GitHub
Jackie-Jiang merged PR #14055: URL: https://github.com/apache/pinot/pull/14055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/io.github.hakky54-sslcontext-kickstart-for-netty-8.3.7 deleted (was 1128062670)

2024-09-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/io.github.hakky54-sslcontext-kickstart-for-netty-8.3.7 in repository https://gitbox.apache.org/repos/asf/pinot.git was 1128062670 Bump io.github.hakky54:sslcontext-kickstar

(pinot) branch master updated: Bump io.github.hakky54:sslcontext-kickstart-for-netty (#14055)

2024-09-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 04f4b31f15 Bump io.github.hakky54:sslcontext-kick

(pinot) branch dependabot/maven/com.github.eirslett-frontend-maven-plugin-1.15.1 deleted (was 367b7be7fc)

2024-09-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.github.eirslett-frontend-maven-plugin-1.15.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was 367b7be7fc Bump com.github.eirslett:frontend-maven-plugin f

Re: [PR] Bump com.github.eirslett:frontend-maven-plugin from 1.15.0 to 1.15.1 [pinot]

2024-09-23 Thread via GitHub
Jackie-Jiang merged PR #14053: URL: https://github.com/apache/pinot/pull/14053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (687659d138 -> 4b8672f454)

2024-09-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 687659d138 Fix vulnerabilities for msopenjdk 11 pinot-base-runtime image. (#14030) add 4b8672f454 Bump com.github

Re: [PR] Bump scala.version from 2.12.19 to 2.13.15 [pinot]

2024-09-23 Thread via GitHub
dependabot[bot] commented on PR #14054: URL: https://github.com/apache/pinot/pull/14054#issuecomment-2368674284 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by

(pinot) branch dependabot/maven/scala.version-2.13.15 deleted (was 4b79003ceb)

2024-09-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/scala.version-2.13.15 in repository https://gitbox.apache.org/repos/asf/pinot.git was 4b79003ceb Bump scala.version from 2.12.19 to 2.13.15 The revisions that were on t

Re: [PR] Bump scala.version from 2.12.19 to 2.13.15 [pinot]

2024-09-23 Thread via GitHub
Jackie-Jiang closed pull request #14054: Bump scala.version from 2.12.19 to 2.13.15 URL: https://github.com/apache/pinot/pull/14054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

(pinot) branch master updated: Fix vulnerabilities for msopenjdk 11 pinot-base-runtime image. (#14030)

2024-09-23 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 687659d138 Fix vulnerabilities for msopenjdk 11

Re: [PR] Fix vulnerabilities for msopenjdk 11 pinot-base-runtime image. [pinot]

2024-09-23 Thread via GitHub
xiangfu0 merged PR #14030: URL: https://github.com/apache/pinot/pull/14030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Part-2: Add Combine and Segment Level Operators for Time Series [pinot]

2024-09-23 Thread via GitHub
ankitsultana commented on code in PR #13999: URL: https://github.com/apache/pinot/pull/13999#discussion_r1771620365 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java: ## @@ -441,7 +444,15 @@ private InstanceResponseBlock executeInte

Re: [PR] Add broker API to run a query on both query engines and compare results [pinot]

2024-09-23 Thread via GitHub
yashmayya commented on code in PR #13746: URL: https://github.com/apache/pinot/pull/13746#discussion_r1771565589 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -236,6 +243,78 @@ public void processSqlWithMultiStageQueryEnginePo

Re: [PR] Add broker API to run a query on both query engines and compare results [pinot]

2024-09-23 Thread via GitHub
yashmayya commented on code in PR #13746: URL: https://github.com/apache/pinot/pull/13746#discussion_r1771564087 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -359,6 +359,8 @@ public static class Broker { public static class Request {

Re: [PR] Add broker API to run a query on both query engines and compare results [pinot]

2024-09-23 Thread via GitHub
gortiz commented on code in PR #13746: URL: https://github.com/apache/pinot/pull/13746#discussion_r1771476794 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -236,6 +243,78 @@ public void processSqlWithMultiStageQueryEnginePost(

Re: [PR] Add broker API to run a query on both query engines and compare results [pinot]

2024-09-23 Thread via GitHub
gortiz commented on code in PR #13746: URL: https://github.com/apache/pinot/pull/13746#discussion_r1771474421 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -359,6 +359,8 @@ public static class Broker { public static class Request {

Re: [PR] Add broker API to run a query on both query engines and compare results [pinot]

2024-09-23 Thread via GitHub
yashmayya commented on code in PR #13746: URL: https://github.com/apache/pinot/pull/13746#discussion_r1771460533 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -236,6 +243,76 @@ public void processSqlWithMultiStageQueryEnginePo

Re: [PR] Add broker API to run a query on both query engines and compare results [pinot]

2024-09-23 Thread via GitHub
yashmayya commented on code in PR #13746: URL: https://github.com/apache/pinot/pull/13746#discussion_r1771460533 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -236,6 +243,76 @@ public void processSqlWithMultiStageQueryEnginePo

Re: [PR] Disable shading when pinot-fastdev profile is enabled [pinot]

2024-09-23 Thread via GitHub
gortiz commented on code in PR #13956: URL: https://github.com/apache/pinot/pull/13956#discussion_r1771409572 ## pom.xml: ## @@ -293,6 +293,7 @@ true true +none Review Comment: This is more added as a comment. Due to how Maven works, in pr

Re: [PR] Disable shading when pinot-fastdev profile is enabled [pinot]

2024-09-23 Thread via GitHub
gortiz commented on code in PR #13956: URL: https://github.com/apache/pinot/pull/13956#discussion_r1771395165 ## pinot-connectors/pinot-spark-2-connector/pom.xml: ## @@ -35,6 +35,45 @@ + + build-shaded-jar + +true + + + +

Re: [PR] Disable shading when pinot-fastdev profile is enabled [pinot]

2024-09-23 Thread via GitHub
gortiz commented on code in PR #13956: URL: https://github.com/apache/pinot/pull/13956#discussion_r1771393553 ## pinot-connectors/pinot-spark-2-connector/pom.xml: ## @@ -35,6 +35,45 @@ + + build-shaded-jar + +true + + + +

Re: [PR] Disable shading when pinot-fastdev profile is enabled [pinot]

2024-09-23 Thread via GitHub
gortiz commented on code in PR #13956: URL: https://github.com/apache/pinot/pull/13956#discussion_r1771386706 ## pinot-clients/pinot-java-client/pom.xml: ## @@ -61,4 +61,13 @@ test + + + + pinot-fastdev + +none + + + Review

Re: [PR] Multi stage explain [pinot]

2024-09-23 Thread via GitHub
gortiz commented on code in PR #13733: URL: https://github.com/apache/pinot/pull/13733#discussion_r1771374971 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/explain/PlanNodeSorter.java: ## @@ -0,0 +1,229 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Multi stage explain [pinot]

2024-09-23 Thread via GitHub
gortiz commented on code in PR #13733: URL: https://github.com/apache/pinot/pull/13733#discussion_r1771372620 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java: ## @@ -270,6 +276,69 @@ private TransferableBlock c

Re: [PR] Multi stage explain [pinot]

2024-09-23 Thread via GitHub
gortiz commented on code in PR #13733: URL: https://github.com/apache/pinot/pull/13733#discussion_r1771360606 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/explain/PlanNodeSorter.java: ## @@ -0,0 +1,229 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Multi stage explain [pinot]

2024-09-23 Thread via GitHub
gortiz commented on PR #13733: URL: https://github.com/apache/pinot/pull/13733#issuecomment-2368149512 The issue should be fixed. Anyway, my error merging this code shown that https://github.com/apache/pinot/pull/13999 is not testing the empty case and also to me it looks like the code that

Re: [PR] Part-2: Add Combine and Segment Level Operators for Time Series [pinot]

2024-09-23 Thread via GitHub
gortiz commented on code in PR #13999: URL: https://github.com/apache/pinot/pull/13999#discussion_r1771350664 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java: ## @@ -441,7 +444,15 @@ private InstanceResponseBlock executeInternal(T

Re: [PR] Part-2: Add Combine and Segment Level Operators for Time Series [pinot]

2024-09-23 Thread via GitHub
gortiz commented on code in PR #13999: URL: https://github.com/apache/pinot/pull/13999#discussion_r1771352558 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java: ## @@ -441,7 +444,15 @@ private InstanceResponseBlock executeInternal(T

Re: [PR] Multi stage explain [pinot]

2024-09-23 Thread via GitHub
gortiz commented on PR #13733: URL: https://github.com/apache/pinot/pull/13733#issuecomment-2368118477 > Thanks @gortiz, LGTM! There are some new tests added in https://github.com/apache/pinot/pull/13999 failing with an NPE here though (and looks related to the explain changes). Yes,

Re: [PR] Multi stage explain [pinot]

2024-09-23 Thread via GitHub
yashmayya commented on code in PR #13733: URL: https://github.com/apache/pinot/pull/13733#discussion_r1771246208 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/explain/PlanNodeSorter.java: ## @@ -0,0 +1,229 @@ +/** + * Licensed to the Apache Software Foundat

[PR] Bump dnsjava:dnsjava from 3.6.1 to 3.6.2 [pinot]

2024-09-23 Thread via GitHub
dependabot[bot] opened a new pull request, #14061: URL: https://github.com/apache/pinot/pull/14061 Bumps [dnsjava:dnsjava](https://github.com/dnsjava/dnsjava) from 3.6.1 to 3.6.2. Release notes Sourced from https://github.com/dnsjava/dnsjava/releases";>dnsjava:dnsjava's releases.

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.28.6 created (now fac19379a0)

2024-09-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.28.6 in repository https://gitbox.apache.org/repos/asf/pinot.git at fac19379a0 Bump software.amazon.awssdk:bom from 2.28.5 to 2.28.6 No n

[PR] Bump software.amazon.awssdk:bom from 2.28.5 to 2.28.6 [pinot]

2024-09-23 Thread via GitHub
dependabot[bot] opened a new pull request, #14062: URL: https://github.com/apache/pinot/pull/14062 Bumps software.amazon.awssdk:bom from 2.28.5 to 2.28.6. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=software

(pinot) branch dependabot/maven/io.grpc-grpc-bom-1.68.0 created (now adee1380f5)

2024-09-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/io.grpc-grpc-bom-1.68.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at adee1380f5 Bump io.grpc:grpc-bom from 1.66.0 to 1.68.0 No new revisions were add

(pinot) branch dependabot/maven/dnsjava-dnsjava-3.6.2 created (now a8cd4e0fc8)

2024-09-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/dnsjava-dnsjava-3.6.2 in repository https://gitbox.apache.org/repos/asf/pinot.git at a8cd4e0fc8 Bump dnsjava:dnsjava from 3.6.1 to 3.6.2 No new revisions were added by

[PR] Bump io.grpc:grpc-bom from 1.66.0 to 1.68.0 [pinot]

2024-09-23 Thread via GitHub
dependabot[bot] opened a new pull request, #14060: URL: https://github.com/apache/pinot/pull/14060 Bumps [io.grpc:grpc-bom](https://github.com/grpc/grpc-java) from 1.66.0 to 1.68.0. Commits See full diff in https://github.com/grpc/grpc-java/commits";>compare view

(pinot) branch dependabot/maven/org.apache.thrift-libthrift-0.21.0 created (now b82972d693)

2024-09-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.thrift-libthrift-0.21.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at b82972d693 Bump org.apache.thrift:libthrift from 0.18.1 to 0.21.0 No

[PR] Bump org.apache.thrift:libthrift from 0.18.1 to 0.21.0 [pinot]

2024-09-23 Thread via GitHub
dependabot[bot] opened a new pull request, #14059: URL: https://github.com/apache/pinot/pull/14059 Bumps [org.apache.thrift:libthrift](https://github.com/apache/thrift) from 0.18.1 to 0.21.0. Release notes Sourced from https://github.com/apache/thrift/releases";>org.apache.thrift:l

(pinot) branch dependabot/maven/org.jline-jline-3.27.0 created (now 45fd5931b9)

2024-09-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.jline-jline-3.27.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 45fd5931b9 Bump org.jline:jline from 3.26.3 to 3.27.0 No new revisions were added

[PR] Bump org.jline:jline from 3.26.3 to 3.27.0 [pinot]

2024-09-23 Thread via GitHub
dependabot[bot] opened a new pull request, #14058: URL: https://github.com/apache/pinot/pull/14058 Bumps [org.jline:jline](https://github.com/jline/jline3) from 3.26.3 to 3.27.0. Release notes Sourced from https://github.com/jline/jline3/releases";>org.jline:jline's releases.

(pinot) branch dependabot/maven/com.github.luben-zstd-jni-1.5.6-6 created (now b3523687d8)

2024-09-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.github.luben-zstd-jni-1.5.6-6 in repository https://gitbox.apache.org/repos/asf/pinot.git at b3523687d8 Bump com.github.luben:zstd-jni from 1.5.6-5 to 1.5.6-6 No

[PR] Bump com.github.luben:zstd-jni from 1.5.6-5 to 1.5.6-6 [pinot]

2024-09-23 Thread via GitHub
dependabot[bot] opened a new pull request, #14057: URL: https://github.com/apache/pinot/pull/14057 Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.6-5 to 1.5.6-6. Commits See full diff in https://github.com/luben/zstd-jni/commits";>compare view

  1   2   >