gortiz commented on code in PR #13956:
URL: https://github.com/apache/pinot/pull/13956#discussion_r1771386706
##########
pinot-clients/pinot-java-client/pom.xml:
##########
@@ -61,4 +61,13 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <profiles>
+ <profile>
+ <id>pinot-fastdev</id>
+ <properties>
+ <shade.phase.prop>none</shade.phase.prop>
+ </properties>
+ </profile>
+ </profiles>
Review Comment:
This is basically what have been added in all `pom.xml` that changes the
default value of `shade.phase.prop`, which is `none` by default (in the root
pom).
In this case (although it is not seen in the PR by default) the value is
changed to package in line 34. This is one of the three methods to change the
property we are using. I've tried to unify them as well, but I don't want to
make this PR more complex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
