Jackie-Jiang commented on code in PR #14014:
URL: https://github.com/apache/pinot/pull/14014#discussion_r1771816298
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TableConfig.java:
##########
@@ -77,14 +77,13 @@ public class TableConfig extends BaseJsonConfig {
private TenantConfig _tenantConfig;
private IndexingConfig _indexingConfig;
- // TODO: Make TableCustomConfig optional and use another key other than
'metadata'
- private TableCustomConfig _customConfig;
-
/* OPTIONAL FIELDS */
@JsonPropertyDescription("Resource quota associated with this table")
private QuotaConfig _quotaConfig;
+ private TableCustomConfig _customConfig;
Review Comment:
(minor) Put this above `QuotaConfig` to maintain the same order
##########
pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexDisabledMultiValueQueriesWithReloadTest.java:
##########
@@ -63,8 +63,8 @@
* TODO: Find a good way to consolidate this with
ForwardIndexDisabledMultiValueQueriesTest
* The <code>ForwardIndexDisabledMultiValueQueriesWithReloadTest</code> class
sets up the index segment for the
* no forward index multi-value queries test with reload.
- * <p>There are totally 14 columns, 100000 records inside the original Avro
file where 10 columns are selected to build
- * the index segment. Selected columns information are as following:
+ * <p>There are totally 14 columns, 100000 records inside the original Avro
file where 10 columns are selected to
+ * build the index segment. Selected columns information are as following:
Review Comment:
This change is unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
