gortiz commented on PR #13733: URL: https://github.com/apache/pinot/pull/13733#issuecomment-2368149512
The issue should be fixed. Anyway, my error merging this code shown that https://github.com/apache/pinot/pull/13999 is not testing the empty case and also to me it looks like the code that was added in `ServerQueryExecutorV1Impl` in that PR should have been added into `ResultsBlockUtils.buildEmptyQueryResults`. @ankitsultana can you take a look at that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
