gortiz commented on PR #13733: URL: https://github.com/apache/pinot/pull/13733#issuecomment-2368118477
> Thanks @gortiz, LGTM! There are some new tests added in https://github.com/apache/pinot/pull/13999 failing with an NPE here though (and looks related to the explain changes). Yes, I've fixed that, but now the same tests fail due to some assertion in the test I don't understand. That is why we need to merge this ASAP. The code in `ServerQueryExecutorV1Impl` is very sensible and it has been modified more often that we used due to the timeseries code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
