ankitsultana commented on code in PR #14048:
URL: https://github.com/apache/pinot/pull/14048#discussion_r1772585067
##########
pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/TimeSeriesBlock.java:
##########
@@ -33,11 +34,12 @@ public class TimeSeriesBlock {
private final TimeBuckets _timeBuckets;
private final Map<Long, List<TimeSeries>> _seriesMap;
- public TimeSeriesBlock(TimeBuckets timeBuckets, Map<Long, List<TimeSeries>>
seriesMap) {
+ public TimeSeriesBlock(@Nullable TimeBuckets timeBuckets, Map<Long,
List<TimeSeries>> seriesMap) {
Review Comment:
Yeah this is for that, and also for the case when we have to perform partial
aggregates. in that case, we might not be able to bucket the values at a time
granularity under the combine operator, and may have to instead return time
values as a Long[] instead of TimeBuckets in the TimeSeries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
